Code Monkey home page Code Monkey logo

Comments (9)

w0rp avatar w0rp commented on May 16, 2024

Test again with the latest code. I took a pretty fair guess as to what the issue is. I believe that now the cleanup code is being run correctly, it deletes the global variables used to track loclists for buffers and such with jobs still running. When jobs complete for buffers which no longer exist, it hits that line and fails.

That's my bet, anyway.

from ale.

w0rp avatar w0rp commented on May 16, 2024

If that fixes the issue, we could consider cancelling jobs for a particular buffer when the buffer is removed.

from ale.

neersighted avatar neersighted commented on May 16, 2024

I'm still seeing the same error. It does seem to happen when I quit during a running ale job, as it only triggers when I quit rapidly after making an edit.

from ale.

w0rp avatar w0rp commented on May 16, 2024

I just made it check for a key in the map now instead. We should look at this more, but that will probably do for a hotfix.

from ale.

neersighted avatar neersighted commented on May 16, 2024

Looks to have fixed it for now. I'll leave this open until we determine the root cause.

from ale.

w0rp avatar w0rp commented on May 16, 2024

My money's on the cleanup code not cancelling jobs. Off the top of my head, the only way to fix that would be to track which jobs are being run for which buffers in a map, and then clear them again.

That might be a decent enhancement over how the plugin currently sets linter.job anyway.

from ale.

neersighted avatar neersighted commented on May 16, 2024

After some testing, looks like you are right, it's a pretty simple race condition. I think it is a good idea to track jobs separately in a global, and clean them in our normal cleanup code.

from ale.

neersighted avatar neersighted commented on May 16, 2024

I'm still not comfortable enough in engine.vim to implement this... Mind taking a crack at it, @w0rp?

from ale.

w0rp avatar w0rp commented on May 16, 2024

I'll give it a go tomorrow.

from ale.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.