suggestion: add hexdump format for `ArrayBuffer` about deno_std HOT 11 CLOSED

Thanks for the feedback! I added it here to a new project https://github.com/halvardssm/deno_stdext 💪🏻 (JSR link)

from deno_std.

Not really, that function only encodes to hex, it does not create a format for debugging as above.

from deno_std.

Like encodeHex()?

from deno_std.

Keep using 3rd party libraries

Which 3rd party libs do you use now?

from deno_std.

None at the moment. I didn't find one I wanted to use since I wanted to keep 3rd party deps to a minimum, so I just created my own.

Here are some that I considered:

• https://www.npmjs.com/package/hexy
• https://deno.land/x/[email protected]

from deno_std.

Maybe let's start with a minimal set of options.

00000000 30 31 32 33 34 35 36 37 38 39 41 42 43 44 45 46 |0123456789ABCDEF|

I think the use of vertical bar can be confusing. How about following the output format of hexy?

function hexdump(buffer: ArrayBufferView): string

Probably we should also support ArrayBuffer input? Some of Web APIs (such as Web Crypto API) return ArrayBuffer instead of ArrayBufferView

from deno_std.

I chose the vertical bars since they align with the output from the hexdump command, and honestly I like it more than the hexy format.

➜  dev echo "Hello World" > hdfile
➜  dev hexdump -C hdfile          
00000000  48 65 6c 6c 6f 20 57 6f  72 6c 64 0a              |Hello World.|

Good idea, lets support both. Any other interface we should also support?

from deno_std.

Can I create a PR, or is there still room for discussion regarding the function?

from deno_std.

It seems unlikely that the average JavaScript developer would ever need this. I'm not for having this in the Standard Library, but I think it'd be a great fit for a third-party module.

from deno_std.

Golang has Dump in encoding/hex which does almost the same thing. https://pkg.go.dev/encoding/hex#Dump

from deno_std.

We discussed this internally and thought such an API would be best in a third-party module rather than the Standard Library. Either way, thank you for the suggestion, @halvardssm! Let us know if you end up publishing 🙂

from deno_std.