Comments (6)
It looks so, here's the problematic bit:
"scripts": {
"test": "make test && make test-cov",
"blanket": {
"pattern": "//^((?!/node_modules/)(?!/test/).)*$/ig",
"onlyCwd": true,
"data-cover-flags": {
"branchTracking": true
}
},
"travis-cov": {
"threshold": 100
}
},
I'll open a PR to deno_npm
later today.
from deno.
🙋 The same with npm:joi
:
import joi from "npm:[email protected]";
console.log(joi);
Works with Deno version 1.43.3.
Fails with Deno version 1.43.4:
error: Error getting response at https://registry.npmjs.org/joi for package "joi": invalid type: map, expected a string at line 1 column 18384
at file:///test.ts:1:17
The url https://registry.npmjs.org/joi, does indeed return json that, at the position given in the error message, contains a run-script value that isn't a string, but a json object. It was present in the ancient [email protected]
, removed in the almost as ancient [email protected]
.
- https://github.com/hapijs/joi/blob/v0.1.0/package.json#L30
- https://github.com/hapijs/joi/blob/v0.2.1/package.json
🫚 Root cause?
I suspect this newly found insensitivity to incorrect package.json
run-scripts, was brought in by this entry in the deno 1.43.4 changelog:
fix(npm): handle null fields in npm registry JSON (#23785)
Following that update, leads to this commit in deno_npm
:
That's how far my understanding goes! I'm not familiar enough with serde in rust to know what the previous default behaviour was, that was apparently overridden here. In general though, for npm compatibility, we might want to be more lenient to parts of json from older versions of modules that we don't even need to use?
from deno.
CC @dsherret can you take a look? Seems like a regression.
from deno.
I think this was caused by denoland/deno_npm#47
from deno.
This is now fixed in Deno 1.43.5
from deno.
Thank you so much @dsherret and @bartlomieju!
from deno.
Related Issues (20)
- FUTURE: `deno install` should interop with other package managers HOT 1
- fails to import a module because of invalid utf8 sequence HOT 3
- Bug: Express errors when sending big file
- Memory leak in `node:vm` HOT 2
- Error running task when `nodeModulesDir` is set to `true` but the `node_modules` directory is absent
- LSP: accepting quick fix inserts import from https://jsr.io URL
- Bug: Panic in Jest
- Perf - Do not do node permission checks when all permissions are allowed
- Cannot execute: required file not found when trying to run in termux
- LSP: Regression in resolving Typescript Dependencies of included Typing files HOT 3
- thread 'main' panicked at inspector.rs:367 internal error: entered unreachable code HOT 2
- Using JSR package in Vite running in Deno HOT 1
- suggestion: expand the functionality of `deno doc --lint` HOT 6
- handle signal 0 on windows as well on process.kill HOT 1
- vendoring file with equals sign in url causes deno publish to fail
- Add `deno doc --html --watch`
- LSP really slow
- Next 15 dev mode error with turbopack HOT 3
- _perf_hooks.PerformanceObserver is not a constructor
- Node imports don't have LSP autocompletion / suggestion
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from deno.