Code Monkey home page Code Monkey logo

Comments (3)

ry avatar ry commented on May 2, 2024 2

I forward them to window.onerror for possible source map modification of the stack trace, and then exit the process.
https://github.com/ry/v8worker2/blob/d2017b36edb8429471b08b27123981f1abd5fcb0/binding.cc#L61-L91

from deno.

benjamingr avatar benjamingr commented on May 2, 2024 1

Following our discussion - we should document the expectation of handling rejections synchronously and keep the current V8 semantic.

I'm going to close this - and follow up with either a docs or code PR (depending on the project state) in 2-3 weeks :)

from deno.

benjamingr avatar benjamingr commented on May 2, 2024

@ry I think that literally exits when a promise is rejected though:

Namely:

const p = makePromise(); // if `p` is rejected synchronously then the process will exit
await 3; // or something else that just waits but not for I/O
p.catch(() => {}); // or await

It is also fine to ask users to handle all promise rejections "synchronously" - it deviates from web behaviour and I think that if this is intentional then it should be documented.

from deno.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.