add Netlify identity widget on admin route about astro-netlify-cms HOT 8 CLOSED

The contributor who added the feature confirmed they could log in successfully so I guess it can work in certain circumstances?

#33 (comment)

from astro-netlify-cms.

Actually tested this myself and I think comments in #33 may have been misleading. Looks like: if you were already logged in before, logging in again without the identity widget works. But if you are trying to log in for the first time (e.g. with a different browser/device or incognito window), you do need the identity widget to make that work.

Given that, I think your proposal of always including on /admin makes sense until we hear otherwise @SeanMcP 👍

from astro-netlify-cms.

Thanks again for offering to make this change @SeanMcP — decided I needed it myself for a project I was working on so got it implemented and released in v0.3.5 🙌

from astro-netlify-cms.

Should be feasible. Maybe we could go for something like:

NetlifyCMS({
  injectIdentityWidget: 'site' | 'admin-only' | false
})

This would default to 'site' and replace the current option for disabling the widget injection.

Would you be interested in making a PR?

from astro-netlify-cms.

Is there ever an instance where you wouldn't want identity on the admin page? An alternative might be to keep the current behavior and just include it in the admin-dashboard.astro component.

from astro-netlify-cms.

Good to know! Being able to log in makes sense, but I wonder how you can invite users without the identity script running somewhere on the site to handle the invite_token.

I guess if you add the option, then it is up to the user to handle.

from astro-netlify-cms.

Sounds good. It's a small change, but I would be happy to make it if that would be helpful.

from astro-netlify-cms.

Absolutely — a contribution would be great!

from astro-netlify-cms.