CI/tests: use tox? about loguru HOT 10 CLOSED

I was a little worried that adding tox would clutter the repository needlessly and badly integrate with Travis, but thanks to tox-travis this is not the case. Using tox is best practice anyway, so there is no reason not to use it.

Thanks for the suggestion! A PR would be much appreciated when you have a little time, as you are surely more used to tox than I am. 🙂

from loguru.

Cool.
I will also add some flake8 and pytest settings along the way: do you prefer to have them in setup.cfg (or maybe pyproject.toml), or within tox.ini then?

I wish to limit the number of files and settings to the bare minimum. If it can fit into the tox.ini, it's perfect.

How would the integration of flake8 looks like? This is very useful to improve overall code quality, on the other hand I don't want the CI tests to fail because of styling issues.

from loguru.

Cool.
I will also add some flake8 and pytest settings along the way: do you prefer to have them in setup.cfg (or maybe pyproject.toml), or within tox.ini then?

from loguru.

Going with tox.ini then.
I would just add some config for flake8, we do not have to inforce it, but it helps already when editing files (I am checking Python files using it by default). What max-line-length do you prefer?

from loguru.

Yes, flake8 integration for local development is something definitely missing in my workflow. This will be of great help, thank you!

The max-line-length should be 100.

from loguru.

@blueyed I can do it if you're too busy.

from loguru.

@qcoumes
Yeah, please go ahead. Thanks!

from loguru.

Alright !

@Delgan Do you want flake8 to be ran on tests/ ? Do you want travis to fail if flake8 fails on loguru/ ?

from loguru.

Thank you for taking care of this @qcoumes! :)

As I never really used them, I don't know how the integration of tox and flake8 will look like. Maybe start with just loguru/ and ignoring tests/ linting? There is quite a lot of files under tests/, and I never paid much attention to write clean code for the tests. I guess it may generate a whole bunch of warnings, I don't know if it worth the effort fixing them all.

One thing is for sure, I don't want flake8 failure to trigger travis build failure. It should help developers identify potential problems and improving code quality, but it should not be mandatory and should not punish contributors.

from loguru.

Closing as it has been fixed. 👍

from loguru.