Code Monkey home page Code Monkey logo

Comments (5)

johnyanarella avatar johnyanarella commented on July 2, 2024

Thanks for reporting this.

I agree, it sounds like the user defined constructor is clobbering the interceptor function that was previously added to the instance to support the controller annotation. I'll look into this immediately.

As of v0.6.6, we migrated the Controllable functionality out of the mix-in itself into a Secha Class system preprocessor. At this point, the mix-in just serves as a marker. (You discovered a bug in the logic used to detect that marker in issue #28.)

NOTE: I strongly suspect we'll be deprecating and removing the Controllable and Injectable mix-ins sometime before the release of v1.0. In the future, you would simply use the controller and inject annotations without needing to include the corresponding mix-in anymore.

from deftjs.

johnyanarella avatar johnyanarella commented on July 2, 2024

After initial investigation, I see where I went wrong with the preprocessor implementation. I plan to get a fix committed for this either later today or tomorrow.

from deftjs.

johnyanarella avatar johnyanarella commented on July 2, 2024

I believe I have resolved this issue locally for Ext JS 4.1 and Sencha Touch 2.01. I'm working on back porting the solution to work with Ext JS 4.0.7 as well. Once I have it working there as well, I'll commit my changes for your review.

from deftjs.

johnyanarella avatar johnyanarella commented on July 2, 2024

The proposed resolution for this issue has been committed. It will be included in the next minor release, but is available now in prerelease form by checking out the master branch on GitHub.

Please let me know if this resolves your issue. Thanks!

from deftjs.

cnstaging avatar cnstaging commented on July 2, 2024

This worked great! Thank you.

I would love to see the use of just controller, rather than the mixin syntax. If you have a ticket for this feature I would like to discuss it further. We have Ext JS core extensions where we register our various preprocessors, We ran into issues with the ExtJS loader, due to it's private closure properties and not being able to define another hook. I wonder what your approaches your considering.

from deftjs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.