Comments (5)
Thanks for reporting this.
I agree, it sounds like the user defined constructor is clobbering the interceptor function that was previously added to the instance to support the controller annotation. I'll look into this immediately.
As of v0.6.6, we migrated the Controllable functionality out of the mix-in itself into a Secha Class system preprocessor. At this point, the mix-in just serves as a marker. (You discovered a bug in the logic used to detect that marker in issue #28.)
NOTE: I strongly suspect we'll be deprecating and removing the Controllable and Injectable mix-ins sometime before the release of v1.0. In the future, you would simply use the controller
and inject
annotations without needing to include the corresponding mix-in anymore.
from deftjs.
After initial investigation, I see where I went wrong with the preprocessor implementation. I plan to get a fix committed for this either later today or tomorrow.
from deftjs.
I believe I have resolved this issue locally for Ext JS 4.1 and Sencha Touch 2.01. I'm working on back porting the solution to work with Ext JS 4.0.7 as well. Once I have it working there as well, I'll commit my changes for your review.
from deftjs.
The proposed resolution for this issue has been committed. It will be included in the next minor release, but is available now in prerelease form by checking out the master
branch on GitHub.
Please let me know if this resolves your issue. Thanks!
from deftjs.
This worked great! Thank you.
I would love to see the use of just controller, rather than the mixin syntax. If you have a ticket for this feature I would like to discuss it further. We have Ext JS core extensions where we register our various preprocessors, We ran into issues with the ExtJS loader, due to it's private closure properties and not being able to define another hook. I wonder what your approaches your considering.
from deftjs.
Related Issues (20)
- DeftJS v0.9 - Promises not working in Internet Explorer 10 HOT 6
- Distribute packages separately. HOT 4
- Update Karma configurations from v0.8 -> v0.10 syntax HOT 1
- Add continuous deployment HOT 10
- Add Ext JS 4.2.2 to the Deft JS Test Suite HOT 2
- Add Sencha Touch 2.3.0 to the Deft JS Test Suite HOT 1
- Update the Test Suite dependencies (Mocha, Chai, Sinon, Promise/A+, etc.)
- Update to Promises/A+ Specification v1.1 and Test Suite v2.0
- Failing to require: the ViewController for a controller: annotation should trigger a warning.
- Sencha Cmd v4.0.0.203 hanging when "requires" : "[email protected]?" added HOT 14
- Migrate back to mixins for Sencha Cmd and Architect compatibility
- Suppress INFO-level log messages when not using the debug build of Sencha Touch HOT 1
- Superclass merging of ViewController 'control:' configurations
- ViewController companions HOT 4
- Touch 2.3.0 coverage report might overwrite 2.2.1 report
- deft.js and deft-debug.js are not in the repo HOT 1
- Sencha cmd 5.0.3 and touch 2.4.1 - build failed HOT 16
- Sencha 2 Routing with Deft JS.. HOT 1
- DeftJS 8.0-9.1Promise/Deferred Memory Usage HOT 5
- Promises catching errors happening in the success method HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from deftjs.