Code Monkey home page Code Monkey logo

Comments (6)

turtlemoji avatar turtlemoji commented on July 25, 2024 1

More questions/comments:

possible updates to hardhat.config.ts to consider:

  1. addgasReporter.excludeContracts: ['contracts/mocks/']

puzzling devDependencies:

  1. when is moment ever used? plus the package is in maintenance mode
  • Moment is removed in current main
  • Agree with the gas reporter
    Now it should be excludeContracts: ['solidity/mocks/'], @alxiong

from solidity-hardhat-boilerplate.

alxiong avatar alxiong commented on July 25, 2024

Ah! I think I was mistaken, we were not intending to use hardhat-storage-layout plugin, but rather smock instead, correct?

Nevertheless, should have stick to:

const config = {
  solidity: {
    settings: {
      outputSelection: {
        "*": {
          "*": ["storageLayout"]
        }
      }
    }
  }
}

instead of

  (config.solidity as MultiSolcUserConfig).compilers = (config.solidity as MultiSolcUserConfig).compilers.map((compiler) => {
    return {
      ...compiler,
      outputSelection: {
        '*': {
          '*': ['storageLayout'],
        },
      },
    };
  });

from solidity-hardhat-boilerplate.

alxiong avatar alxiong commented on July 25, 2024

More questions/comments:

possible updates to hardhat.config.ts to consider:

  1. addgasReporter.excludeContracts: ['contracts/mocks/']

puzzling devDependencies:

  1. when is moment ever used? plus the package is in maintenance mode

from solidity-hardhat-boilerplate.

404skillz avatar 404skillz commented on July 25, 2024

@alxiong thanks for all the input ! It got lost on my notifications. Will look into all of them and ping you back !

from solidity-hardhat-boilerplate.

0xged avatar 0xged commented on July 25, 2024

hey guys! in terms of the contract exclusion of mocks, the bad thing is that if you test against mocks contracts you will not have any of your tests in the coverage.

from solidity-hardhat-boilerplate.

turtlemoji avatar turtlemoji commented on July 25, 2024

@0xged True, closing for now then.

from solidity-hardhat-boilerplate.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.