Improve error message when Zarf can't pull container images when creating a package about zarf HOT 8 CLOSED

#3 is related to user feedback of image actions as well

from zarf.

Is there a specific reason why being unable to pull the image only a warning? After logging the warning I don't see anything that looks like attempted error recovery. If we do a fatal log instead of warn it will be more immediately obvious what broke.

from zarf.

The fatal isn’t the issue here, this is crashing within crane not our code, we need a cleaner way to instrument crane or just replace it.

from zarf.

I think I must be missing something then. It looks to me like crane is crashing because the imageMap gets populated with a nil pointer if we're unable to pull the image from crane.Pull.

If the goal is improving the error message, I think logging a fatal message there would make sense.

from zarf.

Tbh I haven’t debugged this myself yet, but believe that if either 1. The registry is down or 2. The user doesn’t have creds for that registry. But both of those conditions aren’t directly sent to crane by zarf, crane is reading those states on its own.

from zarf.

@jeff-mccoy @YrrepNoj do you know what this looks like now in #237? I can go test it myself of course, just wanted to see if you already knew whether this is still an issue or is mostly resolved in #237

from zarf.

I actually don't recall sorry

from zarf.

I think this can be closed. The current design of the CLI gives generic errors across the board for failures that are much cleaner, but to get more details you can run with debug or trace. This was introduced in #237. I think we can discuss changing that broader approach in another issue if it is warranted.

from zarf.