Ensure only valid host entries are passed to zarf init about zarf HOT 4 CLOSED

Eek sorry I see what you’re saying, I was talking about in zarf init. For regenerate we should make the ui consistent and prompt like init does eventually but for now just leaving as a required (no default value) flag is probably fine.

from zarf.

@jeff-mccoy

36:   pkiRegenerate.Flags().StringVar(&pkiOptions.Host, "host", "zarf-server", "Specify the host or IP for the gitops service ingress")
37:   _ = pkiRegenerate.MarkFlagRequired("host")

https://github.com/defenseunicorns/zarf/blob/master/cli/cmd/pki.go#L36 defines the --host flag as having a default of zarf-server but then also marks the flag as required making it so a user would have to manually put a host no matter what.

This is would be confusing for new (or non-technical) users since cobra compiles the help docs from zarf pki regenerate --help to say --host string Specify the host or IP for the gitops service ingress (default "zarf-server") which implies you don't need to do anything.

Do we want "zarf-server" to actually be a default or do we want to force the user to pass in their own value for the flag?

from zarf.

Actually neither. It’s a bit funkier than that. That’s just legacy code we can probably remove. There are cases where a host isn’t needed at all—such as when you provide your own tls keypair. I think the best thing for now would be to drop the required flag (if it’s required) and the default value. They should still be prompted. Eventually I’d like to not ask for the host name if they aren’t generating pki.

from zarf.

Just to make sure I'm 100% following, the required flag I pointed out was for the ./zarf pki regenerate command. Farther along in the code it uses the hostname to generate the cert. Are you saying it's okay if the hostname is an empty string at this point?

from zarf.