Code Monkey home page Code Monkey logo

Comments (1)

Racer159 avatar Racer159 commented on June 27, 2024

Validated that this is a bug and marked it as a good first issue as well since the logic just needs to be untangled.

Zarf currently supports .tar images here:

zarf/src/internal/packager/images/pull.go

Line 434 in e208cca

if strings.HasSuffix(src, ".tar") || strings.HasSuffix(src, ".tar.gz") || strings.HasSuffix(src, ".tgz") {
- this uses Crane to resolve the image reference and pull in the image.

This code will still do what we want for copying the image and it's layers but we will want to mutate the reference within the list of images in the zarf.yaml component so that Zarf can properly pull from its internal store on deploy. PullAll returns a "pulled" image info array that can be used to perform this check and update the references

zarf/src/pkg/packager/create_stages.go

Line 160 in e208cca

pulled, err = imgConfig.PullAll()
. We'll also have to skip the parse image ref for the tarball since you wouldn't get one in this case: https://github.com/defenseunicorns/zarf/blob/main/src/pkg/packager/create_stages.go#L131

from zarf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.