Code Monkey home page Code Monkey logo

Comments (6)

valentijnscholten avatar valentijnscholten commented on August 15, 2024

I think it's a great idea, but haven't looked yet into the details if it supports all operations. Not sure if everything is in the swagger spec. I remember when browsing the swagger docs on defect dojo some api features are not there.

from defectdojo_api.

edersonbrilhante avatar edersonbrilhante commented on August 15, 2024

Indeed, but I downloaded with curl using token in headers, so I got details that was not available with the browser

curl -X GET  '<endpoint>/api/v2/doc/?format=openapi'  -H 'Authorization: Token<token>' 

from defectdojo_api.

edersonbrilhante avatar edersonbrilhante commented on August 15, 2024

If the swagger is well configured in django-DefectDojo/dojo/api_v2/views.py I think it will not be a problem.

I saw some methods(@action) in ViewSet without swagger_auto_schema, so there are responses and request_bodys wrong.
Example:
api/v2/finding/ = are ok
api/v2/finding//notes/ = are wrong
We fixing that, I think all operations will work

from defectdojo_api.

edersonbrilhante avatar edersonbrilhante commented on August 15, 2024

Hi @valentijnscholten I fixed here DefectDojo/django-DefectDojo#2488

from defectdojo_api.

alles-klar avatar alles-klar commented on August 15, 2024

I created a similar project a while ago: https://github.com/alles-klar/defectdojo-api-v2-client. Generally it works fine but there are some bugs in the defectdojo swagger documentation. So for a stable api client we need to write a lot of tests. @edersonbrilhante do you have an idea how to automatically generate tests?

from defectdojo_api.

edersonbrilhante avatar edersonbrilhante commented on August 15, 2024

@alles-klar My PR fixing some bugs defectdojo swagger documentation was merged to dev.
I am not sure about these tests.

from defectdojo_api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.