When using viewBox attribute, canvas size is not scaled to width and height of svg attribute about svglib HOT 12 CLOSED

@tomturner Anything I can do to help getting this merged ? I recently switched a project from cairoSVG to svglib, and it's the only thing that's still preventing me from completing the transfer.

from svglib.

@Overdrivr just for my own curiosity, why are you switching back from cairoSVG?

from svglib.

Because of the dependency on cairo. I'm fed up with dependencies that are a total mess to install and maintain. Also, now with pipenv enforcing good practices for dependency management, software that rely on hacks to install 3rd party dependencies are doomed to disappear.

from svglib.

BTW in case someone else cannot wait for this patch as well, I have merged this patch with latest master in my own repository, it's available here: https://github.com/cronobo/svglib/tree/i121-viewbox-img-dims
All credits to @tomturner

pip install git+https://github.com/cronobo/svglib@i121-viewbox-img-dims#egg=svglib

I have not checked if it passes CI, I cannot guarantee it's working ok. But it passes extensive unit testing of my own application, so that's a good sign this patch is on the right track

from svglib.

@Overdrivr I need to do some test before I submit the patch again. Hopefully @claudep or @deeplook will then approve it as I need it too. @Overdrivr Have you got a test SVG i can use?

from svglib.

I may not have fixed all concerns in PR #134, but your opinions and tests are welcome there.

from svglib.

@claudep did you see my new code?

from svglib.

Tom, could you make a new PR then?

from svglib.

@tomturner can you confirm you're working on a new PR?

from svglib.

Hi folks, any updates on this ? Otherwise I can open a PR from my repo. I'll add the necessary tests, but otherwise, according to my own application test's suite and extensive use, the modifications on my repo are definitely healthy.

from svglib.

I'm sorry to admit I have never looked enough into this. If we had a contributions file it would state that PRs need to come with tests (ideally maybe even at least two of them). I see there is a test here, which would be ok. But as running the full test suite and checking lots of files visually takes me quite a lot of time, I would entirely trust @claudep to merge #134 if he's ok with it.

from svglib.

My local tests show that at least the use case provided in the initial description is solved now. I'm closing the ticket, feel free to reopen (possibly a new ticket) if you find unresolved cases.

from svglib.