Comments (12)
@tomturner Anything I can do to help getting this merged ? I recently switched a project from cairoSVG to svglib, and it's the only thing that's still preventing me from completing the transfer.
from svglib.
@Overdrivr just for my own curiosity, why are you switching back from cairoSVG?
from svglib.
Because of the dependency on cairo. I'm fed up with dependencies that are a total mess to install and maintain. Also, now with pipenv enforcing good practices for dependency management, software that rely on hacks to install 3rd party dependencies are doomed to disappear.
from svglib.
BTW in case someone else cannot wait for this patch as well, I have merged this patch with latest master in my own repository, it's available here: https://github.com/cronobo/svglib/tree/i121-viewbox-img-dims
All credits to @tomturner
pip install git+https://github.com/cronobo/svglib@i121-viewbox-img-dims#egg=svglib
I have not checked if it passes CI, I cannot guarantee it's working ok. But it passes extensive unit testing of my own application, so that's a good sign this patch is on the right track
from svglib.
@Overdrivr I need to do some test before I submit the patch again. Hopefully @claudep or @deeplook will then approve it as I need it too. @Overdrivr Have you got a test SVG i can use?
from svglib.
I may not have fixed all concerns in PR #134, but your opinions and tests are welcome there.
from svglib.
@claudep did you see my new code?
from svglib.
Tom, could you make a new PR then?
from svglib.
@tomturner can you confirm you're working on a new PR?
from svglib.
Hi folks, any updates on this ? Otherwise I can open a PR from my repo. I'll add the necessary tests, but otherwise, according to my own application test's suite and extensive use, the modifications on my repo are definitely healthy.
from svglib.
I'm sorry to admit I have never looked enough into this. If we had a contributions file it would state that PRs need to come with tests (ideally maybe even at least two of them). I see there is a test here, which would be ok. But as running the full test suite and checking lots of files visually takes me quite a lot of time, I would entirely trust @claudep to merge #134 if he's ok with it.
from svglib.
My local tests show that at least the use case provided in the initial description is solved now. I'm closing the ticket, feel free to reopen (possibly a new ticket) if you find unresolved cases.
from svglib.
Related Issues (20)
- convert to pdf and png files is incorrect HOT 5
- wrong width and height attributes of drawing obj HOT 1
- Implementation error in rendering of paths with shorthand command for quadratic Bézier curves HOT 5
- Transform on clipPath does not work HOT 2
- Error when svg file contains references to font with space in its name HOT 1
- Error on install svglib HOT 2
- Reportlab 4.0.0 added dependency to pycairo HOT 3
- Error ByteIO HOT 3
- svglib fails to render properly HOT 12
- CI failure because of missing cairo HOT 9
- Using root log instead of logger HOT 3
- Units px and pt are wrong HOT 5
- Embedding SVG fonts in PDF/rlg HOT 5
- Add font size test case to test suite
- Rename default branch to main HOT 2
- Add more example and pip install commands to README.md HOT 4
- svglib doesn't remove temporary files properly? HOT 5
- Problems with embedded image sizes HOT 4
- svglib ignores <switch> nodes HOT 4
- Please share wheel file on pypi HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from svglib.