Code Monkey home page Code Monkey logo

Comments (2)

junphine avatar junphine commented on July 4, 2024

still has memory leak, change to this:

/** {@inheritDoc} */
    @Override
    protected NDList forwardInternal(
            ParameterStore ps, NDList inputs, boolean training, PairList<String, Object> params) {
        NDArray input = inputs.singletonOrThrow();
        try (NDManager scope = NDManager.subManagerOf(input)) {
            // on info to the right shapes, see: http://beta.mxnet.io/r/api/mx.symbol.gather_nd.html
            NDArray ids = input.flatten().reshape(1, input.getShape().size());
            // create the embedding Table
            NDArray embeddingTable = ps.getValue(embedding, ids.getDevice(), training);

            scope.tempAttachAll(embeddingTable);
            // We do not perform a sparse lookup, instead we just project into the table
            NDArray result = embeddingTable.gatherNd(ids);
            // we want the original shape of the input + the last dimension of the embedding
            Shape targetShape = input.getShape().addAll(new Shape(embeddingTable.getShape().get(1)));
            return scope.ret(new NDList(result.reshape(targetShape)));
        }
    }

but I not sure embeddingTable will be close when batch finish.

from djl.

frankfliu avatar frankfliu commented on July 4, 2024

@junphine

Your 2nd changes looks good to me, did you observe any issue?

from djl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.