Comments (7)
Carvalho96v2
commented on July 19, 2024
1
I can jump on this
from baobab.
avishkar58
commented on July 19, 2024
Response Controller has been implemented, so this is ready for someone to pick up
from baobab.
Carvalho96v2
commented on July 19, 2024
Hey @avishkar58 , sorry this has taken so long, I've been pretty busy these past few days, looking at this now.
With regards to the unit test, because we're baking this into the post method, wouldn't the existing post method's unit test cover this too? Or would the unit test just cover the content and formatting of the email?
from baobab.
avishkar58
commented on July 19, 2024
Hey, yes the existing POST unit test should be fine, but you might need to
mock out the email service since we don't want to send emails from tests..
…On Wed, 20 Feb 2019 at 15:38 Jean-vicente De Carvalho < ***@***.***> wrote:
Hey @avishkar58 <https://github.com/avishkar58> , sorry this has taken so
long, I've been pretty busy these past few days, looking at this now.
With regards to the unit test, because we're baking this into the post
method, wouldn't the existing post method's unit test cover this too? Or
would the unit test just cover the content and formatting of the email?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#44 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEte7HoC0YvEQc1QQdJuTgKzRiDw0vzyks5vPWvagaJpZM4aqTcF>
.
from baobab.
Carvalho96v2
commented on July 19, 2024
Okay cool, as of right now though we've only got filler data (SMTP host, ports, etc) for the emailer service, so emails don't send at all. Is this correct as is?
from baobab.
avishkar58
commented on July 19, 2024
Yeah that's correct for now, the correct values get filled in between
CircleCI and GCP I believe - there's some on-going discussion around how to
do this for development - maybe we just use a mock service for development
too which writes to STDOUT or something?
…On Wed, 20 Feb 2019 at 15:42 Jean-vicente De Carvalho < ***@***.***> wrote:
Okay cool, as of right now though we've only got filler data (SMTP host,
ports, etc) for the emailer service, so emails don't send at all. Is this
correct as is?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#44 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEte7H92mR-rQg2Ho_zlnvzgN1_L6WBtks5vPWzrgaJpZM4aqTcF>
.
from baobab.
Carvalho96v2
commented on July 19, 2024
Okay sweet, yeah that sounds good
from baobab.
Related Issues (20)
- Remove dates for Continuous Journal Event Type HOT 1
- Use Profile Page
- Remove Dates for Continuous Journal
- Error when using Google Translate
- Journal Submission: Email Admin
- Add Review State to Review Assignment
- Offer and outcome management
- Update travel and acommodation grants to work with tags. HOT 3
- Add tag filters to review assignment
- Add Outcome to Response
- Add reviews to response page
- Send email when a flag is added to a user
- Add document upload functionality
- Depends on question... functionality doesn't seem to work HOT 1
- Event editor not working for extending application deadlines
- Assigning reviewers to individual applications (bug)
- General attendees who haven't registered and haven't paid can still be checked-in
- Form fields being reset to defaults on edit HOT 2
- Removal of Guests from the Invited Guest List HOT 1
- Getting internal server error when trying to view invoice
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from baobab.