Comments (3)
- routing: strict slash method just needs to be applied once to the main router vs apply to all the routes (doc: any subrouters created from that route inherit the original StrictSlash setting.)
- routing: fullRoute := v1.PoliteiaWWWAPIRoute + route is not necessary as we can create a sub router based on a prefix.
- it's not easy to figure out right away the entry point of the repo: remove www.go and separate the logic between main.go (server creation and startup) and server.go
- add graceful shutdown for multiple web servers.
(examples: https://gist.github.com/peterhellberg/38117e546c217960747aacf689af3dc2) - Replace print + os.Exit with log.Fatal (same thing)
- replace go to in the for select with a tag before the for loop called for instance L and do a break L inside the select.
- replace *sessions.FilesystemStore with the interface sessions.Store in the PoliteiaWWW struct.
- name conventions, ex: userHttpCode should be userHTTPCode
from politeia.
@rgeraldes I like these cleanup ideas, although I'm not sure what you're referring to with the last one.
@marcopeereboom what do you think?
from politeia.
I think this has taken too long.
from politeia.
Related Issues (20)
- Slow response on batched pi summaries. HOT 2
- Forbid @ in usernames HOT 2
- [cms] Fresh domain invoices are not shown if using an old month
- politeiavoter: Bunches ignoring interrupt signal.
- comments: Allow retrieving all comment votes.
- Unstable order of data in Proposal Bundle download HOT 6
- comments: Add temporary edits setting. HOT 1
- comments: Add `allowextradata` to the policy reply.
- multi: Add routes page sizes as plugin settings.
- politeiad: MySQL max placeholder limit hit.
- politeiad: Invalid token bug. HOT 4
- tstore: Allow plugins to cache data in the kv store.
- pictl: Return timestamps of all comments when no IDs provided.
- Empty comments are being allowed HOT 1
- mysql/mariadb select statement bug on mac
- Invalidate all sessions of a user on password change
- Cannot Submit Proposal - getting error HOT 1
- Add rate limiting to authenticated password reset HOT 1
- Comments Bundle missing for Abandoned proposals
- [cms] Add grandfathered DCCs
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from politeia.