Code Monkey home page Code Monkey logo

Comments (7)

rodriguesmoises avatar rodriguesmoises commented on June 14, 2024 1

from eo-yaml.

amihaiemil avatar amihaiemil commented on June 14, 2024

@rodriguesmoises Can you do this when you have time? Fork the repo and do the changes on a separate branch, named 11 (as the ticket number)

from eo-yaml.

salikjan avatar salikjan commented on June 14, 2024

Added unit tests for equals and hashCode. I never used JUnit before so i am not sure i've done it right.

from eo-yaml.

amihaiemil avatar amihaiemil commented on June 14, 2024

@salikjan please, move the commit on branch 11 (not sure how, you'll have to look it up) and make a PR :D

from eo-yaml.

salikjan avatar salikjan commented on June 14, 2024

@amihaiemil sorry. today is a first day after long holidays. forgot the order of developing. trying to recall ))

from eo-yaml.

amihaiemil avatar amihaiemil commented on June 14, 2024

@salikjan no worries ^^ I looked over your commit. It looks good, but I have a few comments - I'll let you know in the PR discussion.

from eo-yaml.

amihaiemil avatar amihaiemil commented on June 14, 2024

@rodriguesmoises as you probably saw already, this was solved by @salikjan .

@salikjan Now it was ok, since it was a small task, but generally, if you want to solve a task that you are not assigned to, please ask before. Since maybe, the assignee has already done something on it and it makes no sense that 2 people work on the same thing :D

from eo-yaml.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.