Code Monkey home page Code Monkey logo

Comments (3)

lkdci avatar lkdci commented on July 19, 2024 2

@davidtvs thanks for reporting this bug, great catch!
Thanks for setting up the unit test for this use case, one thing I would comment on, is instead of checking whether the reduced mask_loss is nan, which can results from other unexpected reasons, it's better IMO to check before reduction whether the tensor is an empty tensor which indicate directly that the mask is empty.

mask_loss = mask_loss[mask == 1]  # consider only mask samples for mask loss computing

        if mask_loss.numel() == 0:
            mask_loss = torch.tensor(0.)

We highly encourage new contributors, feel free to open a PR if you find the time to do so. If not we'll push the fix ASAP.

from super-gradients.

lkdci avatar lkdci commented on July 19, 2024 1

This issue is fixed in master branch and will be available in the next version release. #982

Thanks again @davidtvs for reporting the issue.

from super-gradients.

dagshub avatar dagshub commented on July 19, 2024

Join the discussion on DagsHub!

from super-gradients.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.