Certification sp_io dependency about debio-node HOT 4 CLOSED

Also it fails on orders package/workspace.
For all others package:

    certifications
    traits-certifications
    doctor-certifications
    traits-doctor-certifications
    doctors
    traits-user-profile
    electronic-medical-record
    traits-electronic-medical-record
    genetic-testing
    traits-genetic-testing
    traits-order
    hospital-certifications
    traits-hospital-certifications
    hospitals
    labs
    traits-services
    services
    user-profile

are passed.

from debio-node.

I think this has to do with how crate features are defined in Cargo.toml files.
If you go to pallets/certifications/Cargo.toml on line 39 there's sp-io/std. But sp-io is not included in the dependencies, rather it is included in dev-dependencies.
Usually only items in dependencies get included in the std list of the features section.

I changed sp-io/std to sp-std/std since sp-std is included in dependencies and ran cargo check -p node-template-runtime again.
The error disappeared but the same error is also found in doctor-certifiactions pallet. I suspect this error will also be found in other pallets.

Perhaps you would like to take on this task to fix the errors on the other pallets?

As for the reason of the error, i am still not sure. To be honest i still need to get a better understanding on how crate features work.

from debio-node.

@kevinjanada Sure, I'll work on it. Thank you for the guidance

from debio-node.

I've created a PR review (under other DnaSampleStatus PR)
ab36d04

They have been fixed by moving the sp_io and sp_core from dev-dependencies to dependencies in pallets

from debio-node.