Implement `clone` command? about dh-make-golang HOT 10 CLOSED

gbp actually supports gbp clone vcsgit:golang-github-pkg-term. On https://go-team.pages.debian.net/workflow-changes.html, the origin proposal is to set postclone=origtargz in gbp.conf.

from dh-make-golang.

@anthonyfok @zhsj what are your opinions on this?

from dh-make-golang.

gbp actually supports gbp clone vcsgit:golang-github-pkg-term. On https://go-team.pages.debian.net/workflow-changes.html, the origin proposal is to set postclone=origtargz in gbp.conf.

Uh thanks, I should have paid more attention to the documentation.
I suppose adding the postclone directly in our gbp.conf template (in dh-make-golang) won't work?

from dh-make-golang.

I suppose adding the postclone directly in our gbp.conf template (in dh-make-golang) won't work?

It shold work for new package.

from dh-make-golang.

I suppose adding the postclone directly in our gbp.conf template (in dh-make-golang) won't work?

It shold work for new package.

Didn't know if gbp do honor d/gbp.conf of the repository it is currently cloning, I'll try that way and will submit a PR if it works.
Thanks!

from dh-make-golang.

I suppose adding the postclone directly in our gbp.conf template (in dh-make-golang) won't work?

It shold work for new package.

Eh. It doesn't work. from https://manpages.debian.org/testing/git-buildpackage/gbp-clone.1.en.html:

Note that if you clone a repository that contains a hook configuration in debian/gbp.conf this hook will not be run automatically to prevent execution of untrusted code.

Does this clone command still make sense or should team member add postclone hook in their ~/gbp.conf?

from dh-make-golang.

😞 probably this is why it's never implemented although it's mentioned on the website.

I'm not sure what's the preferred way, the implementation for https://go-team.pages.debian.net/workflow-changes.html is in half-way for many years.

from dh-make-golang.

😞 probably this is why it's never implemented although it's mentioned on the website.

I'm not sure what's the preferred way, the implementation for https://go-team.pages.debian.net/workflow-changes.html is in half-way for many years.

In the meantime, I have submitted the PR adding the clone command. Let's see what the others think about that!

from dh-make-golang.

This is awesome @creekorful! And thank you @zhsj for the vcsgit: tip! I never knew that either!
Thank you both!

from dh-make-golang.

The vcsgit tip is on https://go-team.pages.debian.net/packaging.html#_git_setup_for_automatically_authenticating

And there is also a config snip to rewrite https -> ssh for pushing.

from dh-make-golang.