Code Monkey home page Code Monkey logo

Comments (5)

deathau avatar deathau commented on September 24, 2024

Very good points. Will incorporate 👍

from markdownload.

deathau avatar deathau commented on September 24, 2024

I added an indicator of focus and auto-focus on the download button as suggested (for next release).
The styling's a little bit ugly right now (IMO), but I think I need to do a pass and prettify everything anyway.

image

For now I've also made the popup close when the download is triggered. Not 100% sure if this is desirable, but it seems to make sense for a quick-save: ctrl+shift+M, enter and your file is saved and the popup gone so you can get back to what you were doing.

from markdownload.

montemartin avatar montemartin commented on September 24, 2024

This is terrific. Closing on download is exactly the functionality I would expect.

I'm happy to help clean up some of the visuals if you're open to a PR. I've never worked on a browser plugin so I took a quick look through the Firefox docs. I was able to get it operating as a local extension, but when I "Inspect" the extension it opens in a tab with no connect and the popup just loads the spinner and it's too late at night for me to do anymore debugging.

from markdownload.

deathau avatar deathau commented on September 24, 2024

I haven't found a way to inspect the popup HTML elements (granted, I haven't looked very hard either).

Most things are in popup.html and popup.css in the popup folder, but if you also wanted to take a look at the options, they're similarly in the options folder

You might consider doing what I do and installing web-ext (https://extensionworkshop.com/documentation/develop/getting-started-with-web-ext/) as well. I just run web-ext run from the extension folder and it boots up firefox with the extension set up. Then go to about:debugging, go to "this firefox" and you can inspect the background scripts from there.

If you do get it cleaned up, I'd be happy to accept a PR. I've paid practically no attention to how it looks so far 😅

from markdownload.

Kilohertz77 avatar Kilohertz77 commented on September 24, 2024

It's not important enough to open an Issue for, but right now I'm unable to tab to the download button after I've tabbed into the textarea to change something. Pressing tab cycles between the title and the text, not the button.

from markdownload.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.