Broken with Sidekiq 7? about sidekiq-limit_fetch HOT 7 CLOSED

Hi everyone, I did propose some possible fix in #147 and #150. I didn't know much about the sidekiq-limit_fetch implementation, so I can't guarantee that the fix is right and optimal 😬 !

from sidekiq-limit_fetch.

I've just pushed v4.4.0 which should fix this :)

from sidekiq-limit_fetch.

I didn't realise Sidekiq 7 had released but I'll take a look. Can you share your sidekiq.yml?

from sidekiq-limit_fetch.

Sure, it's a pretty simple one:

---
:concurrency: 5
:dynamic: true
:queues:
  - mailers
  - critical
  - default
  - low

And then I have a limit on dynamic queues in the sidekiq.rb:

Sidekiq.configure_server do |config|
  config[:limits] = Hash.new do |_, queue_name|
    queue_name.to_s.starts_with?("proj:") ? 1 : nil
  end
end

from sidekiq-limit_fetch.

Any update on this issue? @xdmx

from sidekiq-limit_fetch.

I'm afraid I've not had chance to properly look into this yet but if anyone finds a fix, feel free to create a PR

from sidekiq-limit_fetch.

If @xdmx and @andreasunterhuber can test PR #150 fixes this, that would be great :)

from sidekiq-limit_fetch.