Multiple cursors for `findText` about vscode-modal-editor HOT 9 CLOSED

Maybe these two issues are related but I'm not sure now. I'll take a closer look at it after I fix the first problem.

from vscode-modal-editor.

That sounds great!

If you have some time, would you mind trying the latest unpublished version? You may need to clone the repo and package it locally.

I should have some time in the next day or two to give it a try.

from vscode-modal-editor.

Hello,

The reason why other cursors vanish is that currently findText changes only the main selection. To fix it, all the selections should be processed in the same way.
You can attempt the change if you are keen on it. If not, I think I can fix it by the end of next week.

from vscode-modal-editor.

I'll let you handle it :) but I am happy to contribute if you get bogged down.

On a related note, I noticed that my "move next word start" (and backward) mapping has an odd behavior. It works for all cursors on the first attempt, but then on the second press it too kills the secondary cursors. I am using your example from helix.js, but I turned it into a function. You can see my entire mapping file here if it is useful helixish.js.

from vscode-modal-editor.

Hi, I think I've fixed findText in the latest commits. Besides, the second issue you mentioned seems to be caused by cancelSelection command, which kills all the secondary cursors if there's any non-empty selection.

So I've added another command called modalEditor.clearSelections that can clear selections but keep all cursors. You can replace the original command with it and it should fix the second issue.

If you have some time, would you mind trying the latest unpublished version? You may need to clone the repo and package it locally.

from vscode-modal-editor.

I have not thoroughly tested, but everything seems to work aside from one thing: I lose secondary cursors when in selection mode and moving backwards.

This does not happen with moving forward (jumping, moving by word, and moving by character all seem to work).

I also tried using the built-in keybindings (multiple cursors at the end of multiple lines; press shift+option+left), and they seem to work fine. For reference, my back-one-word key is just:

"b": repeatable("cursorWordStartLeftSelect"),

I am not sure why this would result in the behavior I described.

from vscode-modal-editor.

Thanks for your feedback. The reason is that the inclusive selection was not implemented correctly for multiple cursors. I've fixed it in the latest commit.

It would be great if you could verify that it works for you as well.

from vscode-modal-editor.

I didn't thoroughly test, but everything I tried is working.

Thanks again.

from vscode-modal-editor.

Great! I'll publish a new version and close this issue later.

from vscode-modal-editor.