Code Monkey home page Code Monkey logo

Comments (2)

fernandobrito avatar fernandobrito commented on June 8, 2024 1

I found this old issue hanging around.

The feature requested on this issue was started on #65 and then tweaked and merged on #83. Thanks, @BAntonellini and @ssassi! 🙌

from dbt-checkpoint.

fernandobrito avatar fernandobrito commented on June 8, 2024

I just started working on this one and I realized that the error message from check-source-has-meta-keys also gives a false impression that the check is checking for the existence of "at least" the meta keys passed as argument.

Example (from the existing test suite):

  • There's a model with meta keys foo and bar
  • The test is executed by running this check with --meta-keys foo
  • The check fails, as the current implementation needs an exact match, and not "at least"

So far, so good. But then the error message to the user is:

aa/bb/with_meta.sql: does not have some of the meta keys defined:
- foo

Which is misleading, since the model does have foo defined.

Just writing here as a reminder to also double-check the error messages on the proposed PR.

from dbt-checkpoint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.