Code Monkey home page Code Monkey logo

Comments (7)

DBaker85 avatar DBaker85 commented on September 15, 2024

Interesting result, it seems HWinfo provides sensor data in MB and HWinfo was not tested.
I can fix it so that it gets converted to GB.

As for the MB / GB, I chose GBs as a compromise as it offers better legibility for on small screens.

Could you provide some extra context regarding why MB would be better?

from astern.

jgrunder avatar jgrunder commented on September 15, 2024

I don't know, I've always been comfortable reading my RAM in MB, I find it's more accurate even if at my level I don't need so much precision. Maybe someone who only has 4 GB of RAM (yes it still exists ^^) or someone for who it' s important to see it in MB (not me in my gaming context, but I think someone might be interested one day).
In a more global way, why not offer the possibility to customize these elements in a separate configuration file?
<param key="ram.unit" value="MB" default="GB" />

from astern.

DBaker85 avatar DBaker85 commented on September 15, 2024

I see.
I think the best solution right now would be to use the unit value returned by the sensor.
Libre Hardware and Open Hardware would return GB and show GB on the Display
HWiNFO would show MB.
I think this is easiest for the average end user rather than providing config files. :)

from astern.

jgrunder avatar jgrunder commented on September 15, 2024

It's up to you, but if you keep it in MB, the 4-digit display takes up too much place in the RAM space. You should probably test the returned unit and adjust the space taken.

from astern.

DBaker85 avatar DBaker85 commented on September 15, 2024

I will split this request into 2 parts.
1 will be the bugfix for the values being returned as MB
I will also open a feature request to consider allowing values between GB and MB 👍

Issue fixed in #6

from astern.

jgrunder avatar jgrunder commented on September 15, 2024

Thank you for the fix, but please note that to convert MB to GB you must divide by 1024 and not 1000

from astern.

DBaker85 avatar DBaker85 commented on September 15, 2024

Indeed.
It seems I got confused about megabytes vs mebibytes.
That 1GB = 1000MB but not when applied to RAM units.
I will fix it in a later update for other fixes that I have planned.

Closing this for now, thanks for the help and suggestions

from astern.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.