Comments (4)
This is still an issue and I vote for having :wrap
as a keyword argument for these layout components.
from re-com.
@skrat h-box
and v-box
are a layer over flexbox but they don't have direct support for wrapping. It hasn't ever been on our radar.
Untested: you might be able to add a flexbox :style
to an h-box
like {:flex-wrap: "wrap"}
.
from re-com.
I just came up against this as well. It seems that adding :style {:flex-wrap "wrap"}
doesn't work, because h-box
and v-box
use :flex-flow "row|column no-wrap"
, and :flex-flow
takes precedence over a separate :flex-wrap
declaration.
Of course, it's possible to pass :style {:flex-flow "row|column wrap"}
as appropriate, but this feels a little silly; h-box
and v-box
already have row|column
specified, so we're duplicating work there. Admittedly, it's not a lot of work, but it makes it more cumbersome to pass around style maps that you might want to share between h-box
and v-box
components.
I see two options here (aside from not doing anything and letting us hack around it):
- Add a
:wrap
option to these components - Have
v-box
andh-box
specify separate:flex-direction
and default:flex-wrap
separately, so that the user can override:flex-wrap
through the:styles
map, as you suggest.
While the former might look nice, the latter might lead to better composability using style maps.
from re-com.
I have created a PR #312 which should fix this issue. The PR allows users to use :wrap
keyword in h-box
and v-box
.
In the case that :wrap
keyword is not passed to re-com, the default of nowrap
remains to avoid breaking changes for current use cases.
from re-com.
Related Issues (20)
- Filter issue when using hiccup for labels in multi-select
- Check-box styling is overridden by browser instead of bootstrap HOT 2
- disabled list should not show on hover background HOT 2
- Conflicting documentation in splits HOT 1
- Datepicker header height increases when a disabled next or previous year button is displayed HOT 1
- Missing icons? HOT 1
- Pass event to popover :on-cancel
- status icon :error has incorrect zmdi-spinner in class
- v-table scrollbar thumb colors are hardcoded (potential PR)
- reagent 1.2.0 reagent.dom/dom-node is deprecated HOT 1
- Bizarre issue with the typeahead component HOT 1
- enhancement: Support :enabled? prop on tab components HOT 1
- horizontal-bar-tabs: Suppress redundant on-click handler calls HOT 3
- Unknown parameter: :parts in tree-select
- Re-com won't build with figwheel-main fig:min HOT 4
- v-table reset! on hover? fails in 2.21.0 but ok in 2.19.0
- simple-v-table: rendering issue/breakage in 2.21.3
- recent changes to v-table still has rendering issues in 2.21.4 HOT 1
- Disabled background colour should be grey in single-dropdown
- Tree Select Dropdown doesn't allow outside clicks HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from re-com.