Comments (5)
@bhanuone @jozzi05 those fix does not remove all counts because other methods like
def total_pages
pager.total_pages
end
next_page
, etc.
also touches ROM's pager.total
indirectly
https://github.com/rom-rb/rom-sql/blob/master/lib/rom/sql/plugin/pagination.rb#L71
that's quite a big issue and seems like can not be fixed by simple "caching" on hanami-pagination side
from hanami-pagination.
@iJackUA I created PR 2 months ago #14 ;)
from hanami-pagination.
@jozzi05 does it really solve issue?
for example when you do
@total = pager.total
@total_pages = pager.total_pages
rom-sql pager has such a code
def total
dataset.unlimited.count
end
def total_pages
(total / per_page.to_f).ceil
end
I wonder is this call
def total
dataset.unlimited.count
end
being cached by rom-sql pager or underlying sequel somehow?
or it still tiggers 2 queris for select count(*)...
?
from hanami-pagination.
In #14 description:
** Only two count queries are left. The first one when total is touched and the second one when total_pages is touched.
from hanami-pagination.
At least one count query has to be fired(total
), and since the total_pages
method has some logic inside rom-sql I left it also as a delegate method.
from hanami-pagination.
Related Issues (7)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hanami-pagination.