asynciterator test fails when run independently about graphql-redis-subscriptions HOT 5 CLOSED

Hey @veeramarni!

Thanks for taking a look here!

Just to clarify as this test is in the current test suite that's passing.
If you run the whole test suite that works?
Could you maybe try uncommenting the code back and just use it.only in order to run the one test?

from graphql-redis-subscriptions.

Yes, basically with all tests it running fine. But the tests that I have pointed were failing. It could be just the test case that was having the issue.

from graphql-redis-subscriptions.

Hmm 🤔
Okay thanks for reporting this issue.
I'll try out when I have a bit more time for maintenance.

Do you see the issue when actually using asynciterator methods?

from graphql-redis-subscriptions.

I've noticed issues with the integration tests myself when working on #108 locally.

When running npm test the Integration tests simply return the following

1) PubSubAsyncIterator should allow subscriptions:
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

I noticed when submitting the PR that jenkins successfully ran those integration tests so wanted to give a bit more information on my environment in case that's relevant.
Node version: 8.9.1
Windows 10
Installation steps before running tests:

• git clone
• npm install
• npm test

from graphql-redis-subscriptions.

Possible cause:
const iterator = pubSub.asyncIterator(eventName);
The subscription takes some time. Even if the promises resolve immediately it waits for the next tick.
If the publish happens right after the call to asyncIterator the global listener is still undefined.
const publishSpy = spy((channel, message) => listener && listener(channel, message));
If all tests are running the reused global listener might already be set.

setTimeout(() => pubSub.publish(eventName, { test: true }), 0)
Should fix the tests but I'm not sure if that is the most elegant solution.

from graphql-redis-subscriptions.