subscriptionMap seems to be leaking memory about graphql-redis-subscriptions HOT 13 CLOSED

I think it's good now!

from graphql-redis-subscriptions.

@davidyaha we may want to reopen that while I assess if it's there!

from graphql-redis-subscriptions.

Yep sorry. Auto closed...

from graphql-redis-subscriptions.

Figured out, that was my bad actually!

from graphql-redis-subscriptions.

Awesome! Thanks for the version bump!

from graphql-redis-subscriptions.

Well, I'm confused, I still see retained objects for no reason:

(that's after the patch)

from graphql-redis-subscriptions.

I have to check if my deploy worked though...

from graphql-redis-subscriptions.

Crossed-checked with local deployment: same issue ... Will need to dive in the code again.

@davidyaha are we sure unsubscribe events are correctly fired ? In that case it may be worth to open an issue in graphql-subscriptions

from graphql-redis-subscriptions.

I'll cross-check with the non-redis, event-emitter based pubsub to see if there is the same issue with it.

from graphql-redis-subscriptions.

@davidyaha: I just figured out what's wrong! You may have forgot to run tsc before publishing ... I don't see the change in my compiled JS ...

from graphql-redis-subscriptions.

Whoops!! Sorry for your wasted time. I usually run tests before publishing so it does that for me. Couple of minutes and I'll release a new version

from graphql-redis-subscriptions.

I made a PR ensuring that kind of stuff doesn't happen again ;)

from graphql-redis-subscriptions.

LMK if this is still the case!

from graphql-redis-subscriptions.