Comments (13)
I think it's good now!
from graphql-redis-subscriptions.
@davidyaha we may want to reopen that while I assess if it's there!
from graphql-redis-subscriptions.
Yep sorry. Auto closed...
from graphql-redis-subscriptions.
Figured out, that was my bad actually!
from graphql-redis-subscriptions.
Awesome! Thanks for the version bump!
from graphql-redis-subscriptions.
Well, I'm confused, I still see retained objects for no reason:
(that's after the patch)
from graphql-redis-subscriptions.
I have to check if my deploy worked though...
from graphql-redis-subscriptions.
Crossed-checked with local deployment: same issue ... Will need to dive in the code again.
@davidyaha are we sure unsubscribe events are correctly fired ? In that case it may be worth to open an issue in graphql-subscriptions
from graphql-redis-subscriptions.
I'll cross-check with the non-redis, event-emitter based pubsub to see if there is the same issue with it.
from graphql-redis-subscriptions.
@davidyaha: I just figured out what's wrong! You may have forgot to run tsc
before publishing ... I don't see the change in my compiled JS ...
from graphql-redis-subscriptions.
Whoops!! Sorry for your wasted time. I usually run tests before publishing so it does that for me. Couple of minutes and I'll release a new version
from graphql-redis-subscriptions.
I made a PR ensuring that kind of stuff doesn't happen again ;)
from graphql-redis-subscriptions.
LMK if this is still the case!
from graphql-redis-subscriptions.
Related Issues (20)
- GraphQL v16 HOT 2
- Update ioredis HOT 1
- pub/sub type safety improvements
- Ability to dynamically add/remove topics to/from asyncIterator
- Fail to startup with IOREDIS v5.0.5 HOT 1
- When filtering on subscriptions, parameters are always undefined HOT 1
- ID of the payload returned by the subscription is always null | undefined HOT 1
- Getting Type 'Redis' is not assignable to type 'RedisClient' on v2.5.0 HOT 2
- issue with Redis , no construct
- Node Redis Support HOT 2
- pubsub.asyncIterator should return an AsyncIterable
- TS2322: Type 'Redis' is not assignable to type 'RedisClient'. HOT 6
- Support sharded pub/sub
- Error: Connection is closed. with pubsub HOT 1
- Race condition with simultaneous subscribe + quick unsubscribe HOT 9
- Please update Readme.md with required redis ACL perms for cluster HOT 1
- Callback when connection is closed?
- graphql-redis-subscriptions version 2.6.0 is not working with Node 16.0.0 HOT 1
- inside docker graphql-redis-subscriptions searches to connect to localhost HOT 2
- Simple example not working with ioredis 5 due to mismatched types HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from graphql-redis-subscriptions.