Make mypy an optional dependency or loosen the dep requirement about poetry-multiproject-plugin HOT 15 CLOSED

Looked at the new pkg and the PKG-INFO has this

Requires-Dist: mypy (==1.)
Requires-Dist: poetry (>=1.2,<2.0)
Requires-Dist: tomlkit (==0.)

which should be fine. Only thing is that since mypy doesn't use semver I forget what their strategy is for a major release change

from poetry-multiproject-plugin.

all seems to work fine now. Many thanks for the quick turnaround David

from poetry-multiproject-plugin.

I'm trying the poetry config system-site-packages = false, need to see if that has other unintended side effects

from poetry-multiproject-plugin.

Thank you for reporting this @nazq!

This is a bug, and should be fixed. I'll look at it right away.

from poetry-multiproject-plugin.

appreciate that. as an fyi the system-site-packages = false didn't quite work

from poetry-multiproject-plugin.

Thank you for reporting this @nazq!

This is a bug, and should be fixed. I'll look at it right away.

What are your thoughts on how to fix this ?

from poetry-multiproject-plugin.

Out of curiosity, how do you add the multiproject-plugin to Poetry? I think that I had thought of it as not disturbing the project specific dependencies, because it being installed in a Poetry-specific virtual environment.

from poetry-multiproject-plugin.

let me try one more thing (might still not work for our CI/CD but worth a try). I'll do the following:-

• Clear proj .venv .tox envs
• Clear all base env packages
• Create a py-build env and only install poetry and the two plugins (plus my own)
• Then poetry install using poetry from the build-env in my proj to create the venv

... should take a few mins

from poetry-multiproject-plugin.

Out of curiosity, how do you add the multiproject-plugin to Poetry? I think that I had thought of it as not disturbing the project specific dependencies, because it being installed in a Poetry-specific virtual environment.

We're not able to use the poetry self add poetry-multiproject-plugin style for poetry in a corp env as we use an internal pypi. So I have to pip install them

from poetry-multiproject-plugin.

ok so that works and I now have a mypy 1.8.0 in the proj env. This will allow me to proceed locally but I se difficulties in creating the py-build venv in our bespoke CI/CD. So some progress

from poetry-multiproject-plugin.

That would explain it, thank you! MyPy is included because of the check-project command. But I think it should be fine for the multiproject plugin to allow any version (i.e. "*").

from poetry-multiproject-plugin.

that would be perfect. I'll upgrade straight away

from poetry-multiproject-plugin.

I see the new version. Many thanks, will give it a try

from poetry-multiproject-plugin.

Great!

I think this problem will re-appear when MyPy releases newer versions, since I am including a lock file (with fixed versions). A possible solution is to exclude the lock file from the deployed package.

from poetry-multiproject-plugin.

@nazq

A suggestion, would it be possible to install the plugin with pip but into the separate Poetry environment? Something like:

$POETRY_HOME/bin/pip install --user poetry-multiproject-plugin

https://python-poetry.org/docs/plugins/#with-pip

from poetry-multiproject-plugin.