Joining the rtree project about rtree HOT 12 CLOSED

Hi Max,
Not working on it at the moment, I finished up its release last Monday. As far as I know it's working fine. Continuous integration shows no failures and it builds fine on my machine. Can you paste in stack traces of the failed tests? Does it build ok from the command line with mvn clean install?

I'd be very happy for any contribution. Just raise an issue like you have or submit a pull request. What's your main interest? Are you looking to contribute to open source in general and hunting around for a project, or does the topic of rtree interest you particularly? Either way I'm glad to receive assistance.

from rtree.

Hi David,
I ran 'mvn clean install' again, rebuilt and now I got 108/108 tests pass :)

Indeed I was looking to contribute to open source in general. I started a full-time job recently, but I still have a few free hours a week which I'd like to spend productively. Your project caught my eye since it's interesting, looks well documented and tested, and rather small so it seemed like a good start.
But I'm open to any suggestions you may have.

from rtree.

Ah good, glad there is no test failure.

There is something you could look at if you like. I'd quite like to get 100% code coverage in cobertura for the project so if you're interested you could inch us towards that. 100% code coverage is no guarantee that the tests are good but it is a metric that can help drive tests somewhat. To see the coverage:

mvn cobertura:cobertua

and open target/site/cobertura/index.html. That will indicate some more tests that could be written. Have a stab if you like.

Make sure you get the latest commits because I added some tests today.

from rtree.

I've never heard of this tool, but it sounds very useful.
I ran it on the project and it looks like the project has good code coverage, almost all modules have 90%+. I'll start writing some tests for the operators module, which has the lowest coverage.

Meanwhile, can you look at this stacktrace for the testVisualizerWithGreekData which fails for me again? I already tried running 'mvn clean install' and rebuilding like last time but this time it doesn't fix it.

from rtree.

I've seen this bug before, it's a bug in rxjava-string that was supposed to be fixed in 0.20.4. Can you paste in the whole stack trace? The confusing thing is that StringObservable L391 doesn't correspond to a line of code in the source, it's javadoc.

from rtree.

I've added StringSplitTest that tests that NPE condition to the project. Get the latest and tell me if that test starts failing for you. By the way has a test ever failed from the command line (mvn clean install)?

You're using Eclipse, did you import the project as a Maven Project?

from rtree.

Hi Max, for whatever reason your stack trace corresponds to using rxjava-string 0.19.x. Do you know why?

from rtree.

Yes you're right, I just noticed I've been using the older jar: rxjava-string-0.19.1.
I switched to 0.20.4. It's still not fixed, but I think it really has to do with the fact that I hadn't imported it as a maven project like you said. When executing cobertura or 'mvn clean install' I always see all tests pass.

Anyway, I'm in the middle of writing some tests so as soon as I'm done with it I'll try to submit a pull request and then import it again as a maven project. I'll let you know if that solves it.

from rtree.

Hi David,
I'm continuing to write tests to achieve maximal code and branch coverage.
I'm having some trouble in the Operators tests. Some lines there aren't covered since the OperatorBoundedPriorityQueue is subscribed. Since I'm new to rxjava, I was wondering, is there a way to forcibly unsubscribe in the process of filling up the queue? And is it a realistic event that we must check?

from rtree.

Yep it's realistic. You can make these things happen predictably by testing with

Subscription sub = 
    Observable.just(1,2,3)
                       .lift(new OperatorBoundedPriorityQueue(params))
                      .subscribe(new Observer<Integer>() {
                             //fill this out and call sub.unsubscribe() when you need to
                             // for example straight after the first onNext call
                       });

from rtree.

By the way where are you Max? Just wondering what the timezone difference is between us.

from rtree.

I'm from Russia.
Currently living and working in Israel. We have quite a difference between us :)

from rtree.