Code Monkey home page Code Monkey logo

Comments (7)

saanvik avatar saanvik commented on June 11, 2024 1

I think I've found the issue. Starting in 28.0.50, the the signature of function make-obsolete to make the third (when ) argument required, when it used to be optional. This appears to be breaking a bunch of things. See https://github.com/emacs-mirror/emacs/blob/f695fdfef7d8e9ea4e0e17b69e0a28f952db55d6/etc/NEWS#L2426

So, this is not a bug in your project, but an issue for packages that don't meet this requirement. The solution is to install a previous version of emacs.

from galactic-emacs.

saanvik avatar saanvik commented on June 11, 2024 1

Thanks, I really appreciate the creation you've made here. Perhaps until this change in 28.0.50 shakes out, you might want to update your README to remove the version 28 instructions and note the issue with version 28.

from galactic-emacs.

saanvik avatar saanvik commented on June 11, 2024

Installing all-the-icons and changing helm-icons-provider to "all-the-icons" resolved the issue with C-x C-f

from galactic-emacs.

saanvik avatar saanvik commented on June 11, 2024

GNU Emacs 28.0.50
Mac OSX Big Sur

from galactic-emacs.

daviderestivo avatar daviderestivo commented on June 11, 2024

@saanvik First of all thanks for using this home-made emacs packages distribution. I'm sorry but I did not see this issue before (I had two very intense days at work). I'ma happy to see you have already fixed all the issues :). Have fun.

P.S.: Please lemme know if you have some advices on what could be improved.

from galactic-emacs.

daviderestivo avatar daviderestivo commented on June 11, 2024

Installing all-the-icons and changing helm-icons-provider to "all-the-icons" resolved the issue with C-x C-f

Can you show me what you have changed, please?

Thanks, I really appreciate the creation you've made here. Perhaps until this change in 28.0.50 shakes out, you might want to update your README to remove the version 28 instructions and note the issue with version 28.

I have reopened the old issue related to the signature of the define-obsolete-function-alias macro and pinned it. I will add more instructions on the REAME during the weekend.

from galactic-emacs.

daviderestivo avatar daviderestivo commented on June 11, 2024

Installing all-the-icons and changing helm-icons-provider to "all-the-icons" resolved the issue with C-x C-f

Fixed in #30

from galactic-emacs.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.