new feature: [MQTTClient] add the timeout connection in parameters about kmqtt HOT 7 OPEN

Indeed changing the TCP connect timeout is not easy, especially considering the many platforms to support. But it is something I would like to implement in the future if possible, so I'll keep the issue open for now.

from kmqtt.

@davidepianca98 I've taken some time to work on that and I found a way... And it wasn't so difficult.

in the ClientSocket.kt (in jvmMain) this little change make the job:

public actual class ClientSocket actual constructor(
    address: String,
    port: Int,
    maximumPacketSize: Int,
    private val readTimeOut: Int,
    checkCallback: () -> Unit
) : Socket(
    SocketChannel.open(), //delay the connection by ignoring the connect information in the constructor
    null,
    ByteBuffer.allocate(maximumPacketSize),
    ByteBuffer.allocate(maximumPacketSize)
) {

    private val selector = Selector.open()

    init {
        channel.socket().connect(InetSocketAddress(address, port), 5000)  //connect with a timeout parameter (nedd to be moved to the constructor parameters
        channel.configureBlocking(false)
        channel.register(selector, SelectionKey.OP_READ)

  //handle the timeout with an exception
        if (!channel.isConnected()) {
            throw Exception("Custom Timeout")
        }
    }

This is a POC implementation but I hope it will help you in your work.

Cheers

from kmqtt.

Hello, thank you for the suggestion! Do you mean the TCP connection timeout or MQTT CONNACK response timeout?
The former is platform specific and probably a bit harder. The latter is very simple. I would like to add both but I am not able to give a timeline.

from kmqtt.

The CONNACK received timeout has been added here c97c4f9

from kmqtt.

Thanks that's great and quick!

In fact I was thinking of the TCP timeout.
My use case is:

• Client start and try to connect before the Broker is live and I would like to change the timeout so I can retry to connect.
  When trying this test I found a consistent timeout of 130 seconds. I'll let you know here if I've found a way to deal with this.

--
edit: The connection timeout came from SocketChannel.open(InetSocketAddress(address, port)) and from what I've seen so far it's not that easy to change the timeout.

Anyway thank for your help!

from kmqtt.

Thanks a lot! I will definitely use this when I get to implement this. Now only the POSIX and JS implementation are needed.

from kmqtt.

Yes, sure, good luck on that ;)

from kmqtt.