Code Monkey home page Code Monkey logo

Comments (16)

davidegironi avatar davidegironi commented on May 29, 2024

Thank you for your submission. Indeed the previous update has something related to column height. Can you please attach some screenshot. It also maybe something related to custom fonts. Also how do you instantiate and setup this component?

from advanceddatagridview.

MattH-Work avatar MattH-Work commented on May 29, 2024

I'm having a similar issue
Just upgraded to the latest build ( 1.2.29016.12 ), not changed any code

Notice the 3 different drop down size, 2 different AdvancedDataGridViews
image
image

Here we have different sizes in the same ADGV
image

from advanceddatagridview.

ccordero44 avatar ccordero44 commented on May 29, 2024

from advanceddatagridview.

davidegironi avatar davidegironi commented on May 29, 2024

Now i see. I think it's something related to the way column appearance. Can you please share your settings, or better reproduce it in a sample project?

from advanceddatagridview.

peros550 avatar peros550 commented on May 29, 2024

Also same issue here on a .net v4.8 application right after downloading latest version.
Loading code of datagridview does not have anythig special.

from advanceddatagridview.

davidegironi avatar davidegironi commented on May 29, 2024

I know where the problem lies but I'm not able to reproduce. Can you please share your settings, or better reproduce it in a sample project?

from advanceddatagridview.

ccordero44 avatar ccordero44 commented on May 29, 2024

from advanceddatagridview.

davidegironi avatar davidegironi commented on May 29, 2024

So, can you create something with the previous release, then switch to the new one to check it has errors?
Please understand that without being able to reproduce this error it's difficult for me to solve this :(

from advanceddatagridview.

davidegironi avatar davidegironi commented on May 29, 2024

I was able to reproduce it.
Can you please test the attached code?
https://file.io/5zd7TFzOIAOE
A couple of detectors for the max header height has been added. One can still increase the maximum amount of height for the image using the MaxFilterButtonImageHeight setting.

from advanceddatagridview.

will-scc avatar will-scc commented on May 29, 2024

I was able to reproduce it. Can you please test the attached code? https://file.io/5zd7TFzOIAOE A couple of detectors for the max header height has been added. One can still increase the maximum amount of height for the image using the MaxFilterButtonImageHeight setting.

Hi Davide,

I have tested and can confirm those changes seem to work as expected now.

Current version (100% scaling):
image

New version (100% scaling):
image

Current version (125% scaling):
image

New version (125% scaling):
image

from advanceddatagridview.

davidegironi avatar davidegironi commented on May 29, 2024

Thanks!
Within a couple of days I'll post a new release and close this issue.

from advanceddatagridview.

davidegironi avatar davidegironi commented on May 29, 2024

Updated version with fix.

from advanceddatagridview.

MattH-Work avatar MattH-Work commented on May 29, 2024

Left image is the drop down from the latest build
Right image is from a previous build ( -2 )

image

Note that the original ( right ) drop down is 16x16, the new ( left ) drop down is 18x18 which seems to cause 'fuzzy' scaling of the icon

from advanceddatagridview.

davidegironi avatar davidegironi commented on May 29, 2024

Thanks for this feedback.
So, it's due to the way the new image size is computed. It's now 0.8 time smaller then the max image dimensions, to allow spacing for top and down borders.
Anyway, can you please download the code and try this.
Change line 40 of ColumnHeaderCell.cs from this
public const int FilterButtonImageDefaultSize = 23;
to that
public const int FilterButtonImageDefaultSize = 20;
That way filter size should be 16x16. If that fix the issue, I'll post this fix soon.

from advanceddatagridview.

MattH-Work avatar MattH-Work commented on May 29, 2024

Unfortunately, didn't work. Icon is still 18x18

image

from advanceddatagridview.

davidegironi avatar davidegironi commented on May 29, 2024

It does not work cause the MaxFilterButtonImageHeight value is overridden by the FilterButtonImageDefaultSize if it's lower than that value.
So you have to recompile one project with FilterButtonImageDefaultSize set to 20

        /// <summary>
        /// Get or Set the max filter button image height
        /// </summary>
        public int MaxFilterButtonImageHeight
        {
            get
            {
                return _maxFilterButtonImageHeight;
            }
            set
            {
                _maxFilterButtonImageHeight = value > ColumnHeaderCell.FilterButtonImageDefaultSize ? value : ColumnHeaderCell.FilterButtonImageDefaultSize;
            }
        }

from advanceddatagridview.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.