Comments (10)
Hey, definitely agree with you; I'll clean it up in a little bit.
Edit: I am going to keep a sample reducer in there just so that the devTools will work properly, but I'll gut most of the other example stuff in terms of components/views/etc.
from react-redux-starter-kit.
Awesome! And thanks for the quick response and resolution
from react-redux-starter-kit.
Hey let me know what you think of this PR: #22
It removes all Todo components, constants, actions, and the unnecessary About view. It keeps a sample reducer/store so that devTools work and show something meaningful, but it's all pretty barebones.
from react-redux-starter-kit.
👍
This looks much better from a starter kit perspective. The only suggestion I'd make is having the Todo example as a separate repo (if you want) because I found your examples useful, not to mention high code quality.
Thanks again!
from react-redux-starter-kit.
Awesome, I'll keep the old one as a branch for now and reference it in the README in case people want to take a look. When I get some time I'll consider pulling it into separate repo like you suggested. Thanks for taking a look!
from react-redux-starter-kit.
This has been implemented with 82a4ee6
from react-redux-starter-kit.
The todo example was really important for me as I could learn how everything works. For example, I was wondering where to put my todo.jsx or todo-list.jsx as it's not a container nor a view.
An other branch is still very fine as long as you/we can keep the todo example synced and up to date. I hope it won't fall behind.
from react-redux-starter-kit.
@ioRekz I'll definitely do my best to keep it updated to reflect any changes to the starter kit. I originally planned on migrating it to another repo, but thinking about it now it almost makes sense to keep it as a branch that way people are free to switch in and out of it while learning/playing around with the starter kit.
Do you think that will work? Or were you more in favor of keeping that in the base starter kit? The example app could go either way, either it being in master with the clean slate being in a branch, or vice versa (as it is currently). The latter makes more logical sense to me, but I could see people being a bit confused by a starter kit that doesn't seem to do too much when they spin it up the first time.
from react-redux-starter-kit.
The branch is actually nice, I didn't see that a lot before but that make sense and it's already more useful for me than a separate repo. Concerning which branch should be master, I'm not sure. For me the todo example was really useful so I can show my team mates how everything works but I understand the benefit of a minimal starter kit. Time will probably tell what people are looking for.
from react-redux-starter-kit.
Yeah we'll just have to wait and see. I'll update the README to make the example branch more prominent and see where that takes us.
from react-redux-starter-kit.
Related Issues (20)
- what is `@import '~bootstrap/scss/bootstrap.scss';` meaning at `src/styles/main.scss` HOT 2
- browserHistory.push change url path but not really loads the component.
- help wanted: Using javascript generator
- Modularizing code (Fractal setup)
- Migration to another project HOT 1
- Seeking New Maintainers HOT 8
- Reuse action creator in other Fractal route container
- verbose stack Error: [email protected] start: `better-npm-run start` HOT 1
- Can I use this kit for react native project?
- bootstrap data-toggle and data-target
- npm run deploy high cpu usage
- Heroku production deployment
- can not import semantic-ui-css/components/button.css
- Implement server side rendering in updated code.
- Implement server side rendering in updated code.
- Unable to create zip with data Node issue
- I am running on AWS Cloud9 HOT 1
- How to save the parameters passed during the routing jump and to apply this parameter when refreshing the page. HOT 1
- Server/main.js Routes
- Safari Unexpected token const
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-redux-starter-kit.