Comments (8)
Hey, I just went and tested a few components after a fresh install and couldn't reproduce this issue. Is there a specific file or code segment that's causing you problems?
Running npm run dev
on localhost:3000
and updating the render method of ~/src/components/todo-list
:
[WDS] App hot update...
app.a0a1c058756778599190.js:10194 [HMR] Checking for updates on the server...
app.a0a1c058756778599190.js:10228 [HMR] Updated modules:
app.a0a1c058756778599190.js:10230 [HMR] - 272
app.a0a1c058756778599190.js:10180 [HMR] App is up to date.
from react-redux-starter-kit.
No, all of them. I'll continue testing then
On Sat, Aug 15, 2015 at 1:14 PM, David Zukowski [email protected]
wrote:
Hey, I just went and tested a few components and couldn't reproduce this
issue. Is there a specific file that's causing you problems?—
Reply to this email directly or view it on GitHub
#15 (comment)
.
from react-redux-starter-kit.
I'm still trying. I observe this only in dev:debug mode. Could you try as well please ? I continue to look for the root problem, thanks
from react-redux-starter-kit.
So hot-reloading works in regular dev
mode, but not dev:debug
? I'll go try myself; the only thing that :debug
adds is the redux-devtools, so I'll look into that.
Edit: Managed to reproduce it with dev:debug
, looking into a fix now.
from react-redux-starter-kit.
So even if I completely disable the devTool middleware and monitoring component, as long as redux-devtools/lib/react
is imported hot-reloading breaks. I'm trying to troubleshoot the issue, but in the meantime I've submitted a bug in the redux-devtools
project: reduxjs/redux-devtools#69
from react-redux-starter-kit.
I've temporarily fixed this by adding redux-devtools
and redux-devtools/lib/react
to the vendor dependencies. Can you please try pulling the latest master branch to see if it's fixed for you?
from react-redux-starter-kit.
fixed for me, thanks ! Just to be sure I understand because I'm new to webpack : this now works because redux-devtools and react-devtools are now bundled in the vendor asset and its not part of the hot reloaded module anymore ?
from react-redux-starter-kit.
Hey, there's a bit more in-depth discussion here: reduxjs/redux-devtools#69, but the gist of it is:
This starter kit is splitting vendor dependencies, which are listed as just simple strings that Webpack matches against imported packages. The key is that Webpack splits on /
's when matching something, meaning the string "react"
will match the package "react"
as well as, unfortunately, "redux-devtools/lib/react"
because it ends up matching against that last "react"
. By explicitly defining both "react"
and "redux-devtools/lib/react"
as packages in the vendor bundle, Webpack will pre-bundle both of them thus solving the issue.
An issue still exists where if you were to bundle anything else that matched "react"
you'd run into the same issue, so I'm still digging around for another fix, but that's a bit of an edge case at the moment.
from react-redux-starter-kit.
Related Issues (20)
- what is `@import '~bootstrap/scss/bootstrap.scss';` meaning at `src/styles/main.scss` HOT 2
- browserHistory.push change url path but not really loads the component.
- help wanted: Using javascript generator
- Modularizing code (Fractal setup)
- Migration to another project HOT 1
- Seeking New Maintainers HOT 8
- Reuse action creator in other Fractal route container
- verbose stack Error: [email protected] start: `better-npm-run start` HOT 1
- Can I use this kit for react native project?
- bootstrap data-toggle and data-target
- npm run deploy high cpu usage
- Heroku production deployment
- can not import semantic-ui-css/components/button.css
- Implement server side rendering in updated code.
- Implement server side rendering in updated code.
- Unable to create zip with data Node issue
- I am running on AWS Cloud9 HOT 1
- How to save the parameters passed during the routing jump and to apply this parameter when refreshing the page. HOT 1
- Server/main.js Routes
- Safari Unexpected token const
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-redux-starter-kit.