204 responses about goblin HOT 5 CLOSED

What would you propose to change for 204 responses?

For the second part, are you referring to breaking up the chunked message that are returned by the server? If so, this is already being done in goblin as messages are deserialized to ogm objects. I think though I prefer to handle this at the ogm level, while having the driver return chunks sized as specified by the server conf. It may seem a little low level, but it gives the driver user more control. I am open to discussing this though...

from goblin.

Re: breaking up the chunks, I guess I was thinking of the chunking as being a transport matter, and not something that needed to be dealt with by code that uses the driver.

I think gremlin-driver doesn't expose messages directly to the driver user, instead returning a ResultSet, a stream of Results.

from goblin.

Yeah, that makes sense I suppose. Do we want to get rid of the concept of the Message entirely then and only return results? Or, should each result be a Message that includes meta data...?

from goblin.

I guess it depends on whether we have a need for Message internally.

from goblin.

Commit 66049a0 resolves this.

from goblin.