Code Monkey home page Code Monkey logo

Comments (3)

rufuspollock avatar rufuspollock commented on June 9, 2024 1

@mohamedsalem401 i wouldn't think too much about optimization at this point - more about the simplicity of the code. (i know i wasn't completely clear on this). so i think the first example is correct. The overall signature for our functions extracting info will be something like:

const listOfXXX = extractXxx(ast, options)

from markdowndb.

mohamedsalem401 avatar mohamedsalem401 commented on June 9, 2024

@rufuspollock,

We can optimize our process even more by iterating through all the nodes of the AST in a single pass. Currently, we perform the following steps:

For Links:

links: source => AST => select all link nodes, select all wiki nodes, select all image nodes

For Tags:

tags: source => AST => select all nodes => get text nodes with a tag e.g., `#Tag`

To improve efficiency, we can consider the following approach:

AST => select all nodes =>
  if (node is a wikilink) => handle wiki links
  if (node is an image) => handle image
  if (node is a tag) => handle tag
  if (node is a task) => handle task

return {tags, links, tasks}

This way, we can consolidate the node selection and handle each node type in a more streamlined manner, potentially saving processing time.

from markdowndb.

rufuspollock avatar rufuspollock commented on June 9, 2024

FIXED in #66

from markdowndb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.