DNS support for UDP transport about php-datadogstatsd HOT 1 OPEN

Just spitballing, since I'm just a dude, not a DataDog dude, but I wonder if a reasonable strategy here would be to extract the behavior of sending socket messages out into its own object. Sending data over UDP is a different responsibility from serializing UDP message strings so they conform to dogstatsd (which is what most of DogStatsd is about), and if a user could supply their own "sender" object, the specific send implementation could be made entirely flexible.

An interface called \DataDog\DogStatsd\Sender that supported a single public method send would be nice. Then you could extract the curl send logic and the UDP over IP send logic into their own Sender implementations.

I had to stub global socket functions at the namespace level to test that the global socket_* functions were being called correctly, which is boilerplate I could avoid if I could instead pass DogStatsd a mock of a Sender implementation.

from php-datadogstatsd.