Code Monkey home page Code Monkey logo

Comments (8)

0xnm avatar 0xnm commented on September 26, 2024 1

Thanks for details! The problem is clear and we will try to address it.

from dd-sdk-android.

0xnm avatar 0xnm commented on September 26, 2024 1

The fix is a part of the 2.6.0 release.

from dd-sdk-android.

0xnm avatar 0xnm commented on September 26, 2024

Hello @geranzo!

Can you please share the way you set these user properties?

Is it done like that:

val propertiesA = mapOf("a" to "b")
GlobalRumMonitor.get().addAction(..., propertiesA)
val propertiesB = mapOf("c" to "d")
GlobalRumMonitor.get().startView(..., propertiesB)

or you are utilizing Datadog.setUserInfo to set them?

Basically code snippets will be useful to understand the setup you have. By looking on the description, it seems that you also start/stop views manually, not using our built-in tracking strategies?

from dd-sdk-android.

geranzo avatar geranzo commented on September 26, 2024

Can you please share the way you set these user properties?

This is our method to set a user property:

    override fun setUserProperty(name: String, value: Any?) {
        if (value != null) {
            globalRum.get().addAttribute(name, value)
        } else {
            removeUserProperty(name)
        }
    }

Basically code snippets will be useful to understand the setup you have. By looking on the description, it seems that you also start/stop views manually, not using our built-in tracking strategies?

Yes, we call globalRum.get().startView(...) ourselves on a callback from Compose Navigation library.

from dd-sdk-android.

0xnm avatar 0xnm commented on September 26, 2024

Thanks for a quick response. Can you please expand removeUserProperty method? Does it call globalRum.get().removeAttribute? And at which point do you call setUserProperty - is it only navigation events?

Also is it possible that calls to send custom action are coming from non-UI thread (shouldn't be an issue, but just for the understanding)?

Yes, we call globalRum.get().startView(...) ourselves on a callback from Compose Navigation library.

We have dd-sdk-android-compose module with NavigationViewTrackingEffect to auto-instrument Compose Navigation. If it doesn't work for your setup, we are open to improve it per your feedback.

from dd-sdk-android.

geranzo avatar geranzo commented on September 26, 2024

Can you please expand removeUserProperty method? Does it call globalRum.get().removeAttribute?

Yes, it does:

    override fun removeUserProperty(name: String) {
        globalRum.get().removeAttribute(name)
    }

And at which point do you call setUserProperty - is it only navigation events?

No, we have a couple more properties that we want to track for the user like e.g. state of a ringer mode or DnD state, theme light or dark etc.

Also is it possible that calls to send custom action are coming from non-UI thread (shouldn't be an issue, but just for the understanding)?

No, every time we are about to call some API like addAttribute, startView or addAction etc., we launch a coroutine on Dispatchers.Main.immediate.

We have dd-sdk-android-compose module with NavigationViewTrackingEffect to auto-instrument Compose Navigation. If it doesn't work for your setup, we are open to improve it per your feedback.

It wasn't probably available at the time we were integrating with DD.

from dd-sdk-android.

mariusc83 avatar mariusc83 commented on September 26, 2024

Closing this as it was fixed and will be delivered in the our next sdk release.

from dd-sdk-android.

geranzo avatar geranzo commented on September 26, 2024

Thank you! Very much appreciated.

from dd-sdk-android.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.