Comments (2)
Created #806 which I think should fix this. I tested this in our stack and now the service
attribute on the logs gets correctly set to the value of the service
tag on the S3 bucket.
from datadog-serverless-functions.
I was looking into the same thing, and I noticed that determining the service is done in https://github.com/DataDog/datadog-serverless-functions/blob/master/aws/logs_monitoring/steps/handlers/s3_handler.py#L53 based on the metadata
object, while the tags set on the S3 bucket are only added to the metadata object afterwards in https://github.com/DataDog/datadog-serverless-functions/blob/master/aws/logs_monitoring/steps/handlers/s3_handler.py#L55, which would explain why these tags are ignored for determining the service
attribute.
So I believe running self._add_s3_tags_from_cache()
before add_service_tag(self.metadata)
should solve that (didn't test this yet though).
from datadog-serverless-functions.
Related Issues (20)
- Feature Request: Support reading API Gateway Access Logs from an S3 bucket HOT 2
- Azure Auditing logs to Datadog through EventGrid streamed incorrectly
- AWS Cloudformation configuration does not allow configuration of DD_LOG_LEVEL
- Feature Request: Datadog Forwarder Cloudformation - configurable Cloudwatch log group storage class
- Add new region `ca-west-1` to Datadog-Forwarder layer HOT 1
- [BUG] DD_TAGS envar no effect
- Bug in parsing.py:get_service_from_tags_and_remove_duplicates()
- AWS S3 Bucket lifecycle rule for aborted multipart uploads
- AWS S3 Securityhub finding about target access-logs bucket not configured HOT 2
- Error: cannot open shared object file: No such file or directory HOT 1
- python runtime >= 3.11 required
- aws-dd-forwarder Timeout error after 3 sec HOT 1
- CloudFormation Stack and Terraform Deployment Issues: Empty `index.py` File
- AWS Datadog forwarder 3.111.0 results in import error HOT 1
- Add TagFiltering Option with the DD Log Forwarder Parameters HOT 2
- AWS log forwarder CloudFormation template intermittently fails to deploy because it can't get the role ARN
- AWS log forwarder CloudFormation template fails to deploy because it can't call lambda:GetLayerVersion (AccessDenied) .
- Azure - Managed Identity use instead of SAS key connection string
- Support for using Lambda arm architecture. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from datadog-serverless-functions.