Allow beforeSend callback about browser-sdk HOT 7 CLOSED

We'll have to talk a bit about it internally. The issue is, if we want to filter events, we can't do this at the same place as beforeSend, because (for example) when an Error event is generated, it increments the View event view.error.count field. If we want to filter-out the Error event, we should make sure the count does not get incremented.

from browser-sdk.

This has been implemented in v2.5.5

from browser-sdk.

We are working on it. We implemented a beforeSend callback to edit sensitive data, but doesn't support canceling the data sent yet.

from browser-sdk.

Hi @gabceb!

That is an interesting feature indeed, we will work on it soon.

from browser-sdk.

any info on this, I got so many XHR request error from algolia instantsearch when user decide to correct their search

from browser-sdk.

@BenoitZugmeyer Is this something one could implement and make a pull request? I would really love to see this feature and could try implementing it (if that's fine for you - at least I'd assume based on the CONTRIBUTION guideline).

I think it could be implemented fairly easy by giving the option to return a boolean in the existing beforeSend callback. Depending on the returned value, RUM could either send the event to Datdog or cancel the sending.

datadogRum.init({
    ...,
    beforeSend: (event) => {
        // Example: don't send failed requests google analytics
        return !event.error.resource.url.startsWith('https://www.google-analytics.com');
    },
    ...
});

If the beforeSend function shouldn't be used for this, adding a new callback filterEvent(event: Event): boolean would also work.

from browser-sdk.

Amazing. Thank you @BenoitZugmeyer

from browser-sdk.