Terminology: index, subset, and extract about r-socialsci HOT 8 CLOSED

Hi @eirini-zormpa! You are most welcome, and I would be happy to attempt a pull request with some suggested changes. It might take me a little time (I haven't done a pull request before), but I will reach out if I run into issues.
Thanks again!

from r-socialsci.

Hello @eirini-zormpa!

I have reviewed the documentation on how to create a pull request, forked the repository, and created a branch within my fork. (I hope I am using the GitHub terminology correctly!) I named my branch /indexing-terminology.

Before I go too much further, I want to make sure I'm headed in the right direction. It appears that the next step is to edit the code for the episode directly within this branch and then commit the change. However, it gives me the option of committing the change to my branch or "Create a new branch for this commit and start a pull request." Please let me know which option I should choose and whether I'm on the right track.

Thanks so much!

from r-socialsci.

@catherineromerobarber these are great ideas for improving clarity! @datacarpentry/r-socialsci-maintainers this would be a great candidate for good first issue and help wanted labels.

from r-socialsci.

@catherineromerobarber I think I understand what Github is doing. When you make a pull request in a branch you don't have write access to (like the main lesson branch) it will automatically ask you to make a fork to make changes there. But since you already created your own branch before making the PR, you have the options of making a sub-branch OR editing your main branch. Sometimes sub-branches help with longer term development, but here you want the main branch.

So if you hit edit in your repo, it's best to edit and commit directly.
Then, go to this repo and create a new pull request. Near the top, you should see a link to "compare branches" and if you click that, you should be able to find your branch and it will detect the difference and help you make the request.

For bonus points (since you're learning cool git skills today apparently), if you mention #432 in the pull request description, it will also tag this issue and connect them both ways so it's easy to track.

Let us know if you have more issues! And thanks for contributing!

from r-socialsci.

Thanks, @ndporter! I will try this and reach out if I have any other issues. I'm happy to have the chance to contribute while building my skills!

from r-socialsci.

Thank you for pointing these things out @catherineromerobarber ✨ Would you be interested in having a go at making these changes and submitting a pull request? And we're here for support, if you'd need any help of course 😊

from r-socialsci.

Let us know how we can help 😊

from r-socialsci.

Thank you so much @catherineromerobarber ✨ I'll have a look and review as soon as possible 😊

from r-socialsci.