Code Monkey home page Code Monkey logo

Comments (7)

egeland avatar egeland commented on May 13, 2024 1

From some investigation, we are hitting the github api rate limit (NAT'ed egress IP from an office full of developers). This impacts the download script as you use the API to find the latest release.

from helm-diff.

databus23 avatar databus23 commented on May 13, 2024

Ah that darn github api rate limit...
I could try to guess the download url from the plugin version and platform instead of using the api for getting the download url.
To be honest I just copied the install script from helm-template and haven't given it much thought.
I'm going to leave this open for now and wait a bit to this if this is a frequent problem that needs fixing.

from helm-diff.

egeland avatar egeland commented on May 13, 2024

Maybe just returning the error from the curl attempt would help people understand what the problem is.
Other than that, maybe add the option to use an API token (from an env var) to get around the unauthenticated api limits?

from helm-diff.

mellowplace avatar mellowplace commented on May 13, 2024

I think I've just hit this problem in a Docker build...

Downloading 
curl: (3) <url> malformed
Failed to install helm-diff
\tFor support, go to https://github.com/databus23/helm-diff.
Error: plugin install hook for "diff" exited with error

from helm-diff.

helgi avatar helgi commented on May 13, 2024

#69 fixed this for the scenario when you ask for a specific version; The GH API is still used to determine the latest version.

from helm-diff.

rajiteh avatar rajiteh commented on May 13, 2024

Still seeing this issue.

helm --debug plugin install https://github.com/databus23/helm-diff --version master
[debug] cloning https://github.com/databus23/helm-diff to /root/.helm/cache/plugins/https-github.com-databus23-helm-diff
[debug] setting version to "master"
[debug] symlinking /root/.helm/cache/plugins/https-github.com-databus23-helm-diff to /root/.helm/plugins/helm-diff
[debug] loading plugin from /root/.helm/plugins/helm-diff
[debug] running install hook: &{/bin/sh [sh -c $HELM_PLUGIN_DIR/install-binary.sh] []  <nil> <nil> <nil> [] %!s(*syscall.SysProcAttr=<nil>) %!s(*os.Process=<nil>) <nil> <nil> <nil> %!s(bool=false) [] [] [] [] %!s(chan error=<nil>) %!s(chan struct {}=<nil>)}
Downloading 
Failed to install helm-diff
\tFor support, go to https://github.com/databus23/helm-diff.
curl: (3) <url> malformed
Error: plugin install hook for "diff" exited with error

from helm-diff.

stale avatar stale commented on May 13, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from helm-diff.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.