YAML aliases with Ruby 3.1 about database_cleaner HOT 8 CLOSED

I added a monkey patch in an initializer:

if defined?(DatabaseCleaner)
  module DatabaseCleaner
    module ActiveRecord
      class Base
        private

        def load_config
          if db != :default && db.is_a?(Symbol) && File.file?(DatabaseCleaner::ActiveRecord.config_file_location)
            connection_details = YAML::load(ERB.new(IO.read(DatabaseCleaner::ActiveRecord.config_file_location)).result, aliases: true)
            @connection_hash   = valid_config(connection_details, db.to_s)
          end
        end
      end
    end
  end
end

from database_cleaner.

@jacobat Thanks for submitting this issue! Would you be interested in submitting a PR so that people no longer have to use that monkey patch?

from database_cleaner.

Same problem over here. It "works" if I remove database cleaner.

@jacobat, did you find some solution? The only way I found was to remove alias at database.yml and duplicate all the config.

from database_cleaner.

Thanks, man! 🤜🤛

from database_cleaner.

@etagwerker I believe this is fixed on active_record adapter on https://github.com/DatabaseCleaner/database_cleaner-active_record/blob/v2.1.0/lib/database_cleaner/active_record/base.rb#L57 but we need a new version of database-cleaner released with a loosen restriction on https://github.com/DatabaseCleaner/database_cleaner/blob/main/database_cleaner.gemspec#L19 otherwise we can't update the active-record adapter with the fix with an bundle update database_cleaner-active_record.

This is the fix: DatabaseCleaner/database_cleaner-active_record@b750ac7

I suggest using just ~> 2 there to easy future updates to get minor and patch fixes.

from database_cleaner.

@jvortmann Sounds like a good idea. Thank you!

from database_cleaner.

Thank you!

from database_cleaner.