Code Monkey home page Code Monkey logo

Comments (12)

darylhjd avatar darylhjd commented on June 25, 2024

thanks for reporting!

Regarding:

  1. The reason this happens is because the application uses the en title to show the title and store the files, but sometimes people add it such that the titles end up being in other language tags. For the manga you mentioned, the English name went to the ja tag.
  2. This was an oversight on my part. In the meantime, I am thinking of replacing the . characters in the name with _ characters as of now.

from mangadesk.

darylhjd avatar darylhjd commented on June 25, 2024

The first bug might be harder to fix simply due to how the API is structured (it's not very consistent with the data types it returns), but the 2nd one should be an easy fix.

from mangadesk.

dimox99 avatar dimox99 commented on June 25, 2024

Regarding 1 - hm, what would be your solution then? Maybe use the japanese title instead, or the Manga ID?
Regarding 2 - sounds good, no issues with that

from mangadesk.

darylhjd avatar darylhjd commented on June 25, 2024

i could make the ID a part of the folder name, so at least a subfolder for the manga is created when downloading (without the english title, if its missing).

as for displaying the title, im not too sure yet. the API data is not pretty and would require me to jump through quite a few hoops if a english title isnt present, and even so theres no guarantee trying to get an alternate title yields what we want (maybe someone added a japanese title in the en field haha). theres only so much you can do when given bad data.

from mangadesk.

dimox99 avatar dimox99 commented on June 25, 2024

Hm, always adding those IDs might cause different issues, I guess. The new manga IDs are quite long now, so that's wasting a lot of characters, considering that the combined length of filename+folderpath have their limits. Maybe only use instead of an otherwise blank title?

from mangadesk.

darylhjd avatar darylhjd commented on June 25, 2024

yea its not pretty. altho i could just not think so hard and just work with whatever data im given.

anw i dont really have the time to get to bottom of this rn, so ill think abt it when i have the free time.

in the meantime tho i should be able to release a fix just for the 2nd issue.

from mangadesk.

dimox99 avatar dimox99 commented on June 25, 2024

Albeit it's a bit inconvenient for such titles, Mangadesk still works with them. Just take your time to find a proper solution.

from mangadesk.

dimox99 avatar dimox99 commented on June 25, 2024

Hi,

is the issue regarding wrong language (Bug 1) also the reason why certain titles cannot be found in Mangadesk - at least for me they cannot be searched for:

Examples:
https://mangadex.org/title/1e8d04cf-400c-4ffb-af6b-108d851f1b7d
https://mangadex.org/title/21b848be-1bfe-4f97-b92c-62d319d8a093

I mean, especially the second title should be easy to find if you look for "giant" but no matter what I try, the search simply returns "no results".

One thing that's special with those two is that they seem to have no description either. At least if I look at them on Mangadex there is none.

from mangadesk.

darylhjd avatar darylhjd commented on June 25, 2024

it is due to how the api wrapper i am using for the application parses the data (it cant parse it correctly, so it errors out/doesnt show it).

from mangadesk.

dimox99 avatar dimox99 commented on June 25, 2024

So, that doesn't sound like an easy fix...

One other strange thing I noticed with searches is that a title may or may not be found depending on the exact keyword you search for. Some seem to not work at all. A good example would be this one:

https://mangadex.org/title/26dd4eae-1bf7-4834-986b-40914cbd5816

Search for "license", "manamusume" or even something plain like "daughter" and it will show up. Well, ofc "daughter" produces quite the list, but the title is still there. Now search for "Boukensha" instead and the list returns... "no results". now that's weird considering the number of titles that should contain this keyword.

Only reason I can imagine here is that there might even be too many results for "Boukensha".

from mangadesk.

darylhjd avatar darylhjd commented on June 25, 2024

yup. they were changing the API designs rapidly and it was hard to keep up, so now theres quite a few errors haha,

from mangadesk.

dimox99 avatar dimox99 commented on June 25, 2024

Yeah, haha. Now they changed API again, I guess. On opening Mangadesk, you now you get "Error loading manga list".

But it's not completely broken. Searching for titles still seems to work, if we exclude above mentioned problems.

from mangadesk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.