Integration is using deprecated `DEVICE_CLASS_*` constants about wienernetzesmartmeter HOT 7 CLOSED

Oh no! Get well soon 🚑 🩹

from wienernetzesmartmeter.

Ah good idea! Thanks for the insight, I might migrate it as soon as I am not sick anymore 🤧

from wienernetzesmartmeter.

Excuse me being a total newbie, this is my first GIT comment ever (and I am no coder at all)
While you awesome guys are at it:
Similar to what you did in #39
I think you might want to also change the Energy units "kWh" over to the new enum.

In File wnsm/sensor.py

change line 19
OLD: ENERGY_KILO_WATT_HOUR,
NEW UnitOfEnergy,

in Line 97 and 98
OLD: "ENERGY_KILO_WATT_HOUR"
NEW: "UnitOfEnergy.KILO_WATT_HOUR"

This has change has been introduced by home-assistant/core@842cb18

@frenck seems to be the man knowing if I am talking total BS or if it is worthwhile.

Thanks to all!
HST

from wienernetzesmartmeter.

@HSteindl Yes, you are right. We have many more new enums around and many more constants that have been deprecated (like all state class and unit constants).

For example, the energy enum you are referring to has been introduced in Home Assistant Core 2022.11 for the first time, and we still need to complete the entire migration in Core at this point.

That said, if a custom integration starts using those now, it would mean that for anyone using an older version of Home Assistant (before 2022.11), the custom integration would break.

For Core development, we have the advantage of not having to support multiple Home Assistant versions like custom integrations.

../Frenck

from wienernetzesmartmeter.

Thanks @frenck for this valuable input.

Get well soon @TheRealVira 💊

from wienernetzesmartmeter.

Awesomely fast resolved! Thanks!

Happy New Year 🥂

../Frenck

from wienernetzesmartmeter.

Hi @HSteindl and @frenck

Thanks a lot for your input and your participation.

@HSteindl no need for an excuse, any contribution or input is welcome. Especially if it's something we are currently not aware of dealing with. e.g. dealing with changes in Home Assistant.

I'm trying to keep track of the changes in Home Assistant, but lack the time currently to look at all the release notes.

@frenck What would be your suggestion to look at when it comes to deprecation and new developments, summarized in a easily digestible manner, so we can inform ourselves and document it properly in this project?

from wienernetzesmartmeter.