Collecting coverage from dartium or content_shell fails due to JsonRpcError about coverage HOT 10 CLOSED

@cbracken @kevmoo

from coverage.

Which (exact) version of the VM are you using? The observatory protocol hasn't yet been declared stable, so it changes frequently-ish, sometimes in ways that break coverage.

Side Note: Is --remote-debugging-port necessary?

It was necessary until quite recently. Around v1.9 or 1.10 of Dartium, it was moved to its own port and we eliminated the old chrome-remote-debugging websocket protocol. Given that we've started eliminating support for older observatory protocols in this package, we can remove that from the instructions.

from coverage.

@cbracken I was using 1.11.1, but I just upgraded to 1.11.3 and saw the same issue. I can try the development channel and see if that helps.

from coverage.

@cbracken okay I tried it with the latest dev version (1.12.0-dev.5.1) and still got the same error.

from coverage.

@cbracken @kevmoo any ideas on this? Are either of you able to reproduce what I'm seeing?

from coverage.

@evanweible-wf Did this work in 1.10? I'll take a look quick...

from coverage.

@kevmoo I dug into this a bit more. I stepped back through the commit history and found f5b4ef8 to be the commit that introduces the code that throws the RPC error. Ever since that commit, browser coverage fails due to that error, but I think it's a false negative prior to 1.11.

If I use the commit just before that one (0d8d903), I get the following results:

• 1.10.0: coverage collects successfully
• 1.10.1: coverage collects successfully
• 1.11.0:
  SEVERE: 2015-08-13 16:36:29.492: Failed to get JSON response for message 2 The null object does not have a method '[]'.

So it looks like 1.11 is when the protocol communication changes and browser coverage actually stops working.

Also, I erroneously wrote above in the original issue description that I was trying to run dartium with a .dart file - obviously that doesn't work. It was supposed to be an .html file that simply loads a .dart script. I've updated that now.

from coverage.

Interesting...will let you know what I come up w/

On Thu, Aug 13, 2015 at 2:40 PM, Evan Weible [email protected]
wrote:

@kevmoo https://github.com/kevmoo I dug into this a bit more. I stepped
back through the commit history and found f5b4ef8
f5b4ef8
to be the commit that introduces the code that throws the RPC error. Ever
since that commit, browser coverage fails due to that error, but I think
it's a false negative prior to 1.11.

If I use the commit just before that one (0d8d903
0d8d903),
I get the following results:

• 1.10.0: coverage collects successfully
• 1.10.1: coverage collects successfully
• 1.11.0: SEVERE: 2015-08-13 16:36:29.492: Failed to get JSON response
  for message 2 The null object does not have a method '[]'.

So it looks like 1.11 is when the protocol communication changes and
browser coverage actually stops working.

Also, I erroneously wrote above in the original issue description that I
was trying to run dartium with a .dart file - obviously that doesn't
work. It was supposed to be an .html file that simply loads a .dart
script. I've updated that now.

—
Reply to this email directly or view it on GitHub
#98 (comment).

from coverage.

Closing. User error. Please open an issue about a better error message – it wasn't very clear that resume is only needed if things are paused. 😄

from coverage.

Thanks again! :)

from coverage.