Code Monkey home page Code Monkey logo

Comments (4)

lrhn avatar lrhn commented on June 12, 2024

Not clear what should be changed. Can you elaborate?

from async.

natebosch avatar natebosch commented on June 12, 2024

Sorry, I mistyped the name.

This is a tracking issue for:

// TODO(nweiz): When we release a new major version, get rid of the second
// type parameter and avoid this conversion.

This was never intended to be used in any way other than the case where both generics are the same.

Concretely, this class should be defined as:

/// A transformer that converts a broadcast stream into a single-subscription
/// stream.
///
/// This buffers the broadcast stream's events, which means that it starts
/// listening to a stream as soon as it's bound.
class SingleSubscriptionTransformer<S> extends StreamTransformerBase<S, S> {
  const SingleSubscriptionTransformer();

  @override
  Stream<S> bind(Stream<S> stream) {
    StreamSubscription<S> subscription;
    var controller =
        StreamController<S>(sync: true, onCancel: () => subscription.cancel());
    subscription = stream.listen(controller.add,
        onError: controller.addError, onDone: controller.close);
    return controller.stream;
  }
}

from async.

lrhn avatar lrhn commented on June 12, 2024

Ack.

FWIW, I'd implement it as:

  @override
  Stream<S> bind(Stream<S> stream) {
    var controller = StreamController<S>(sync: true);
    controller.addStream(stream).whenComplete(controller.close);
    return controller.stream;
  }

(I also think it's a bad idea to listen immediately and buffer an unboundend number of events, but if that's the desired semantics, I guess it has to happen).

Let's make the Null Safe release a new major version, that should let us fix things like this.

from async.

natebosch avatar natebosch commented on June 12, 2024

Let's make the Null Safe release a new major version, that should let us fix things like this.

We really hope to be able to do that 😄

from async.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.