Comments (4)
DanTup
commented on June 26, 2024
@kenzieschmoll is it ok to send both? That would avoid me needing to do any version checks, I could just always include &embed=true&embedMode=one.
from dart-code.
DanTup
commented on June 26, 2024
I've pushed a change assuming this is fine (I review the code in the DevTools PR and it seems to only check the old value if the new one isn't present). If you think there will be any issue doing this, let me know and I can revise.
from dart-code.
kenzieschmoll
commented on June 26, 2024
This should be fine. For cleanup purposes, can we remove the legacy flag in a year or two?
from dart-code.
DanTup
commented on June 26, 2024
Generally I try to keep Dart-Code compatible with as many old SDKs as possible so rather than just delete it, I've added in a version check so we'll stop sending embed=true from Dart SDK 3.7.0-0 (and for anything earlier, we just send both... so I don't need to set an exact version that matches the changeover).
from dart-code.
Related Issues (20)
- Server diagnostics can reappear for deleted/moved files if analyzer plugins generate new diagnostics (even if empty) HOT 7
- Macro not detected when importing from a package HOT 2
- The SDK configured in dart.flutterSdkPath is not a valid SDK folder. HOT 1
- Widget Inspector breaks when its tab is undocked or re-docked. HOT 1
- Improved ASDF Support HOT 8
- having issues in flutter launching HOT 1
- Can't install Flutter SDK - Stuck on "Checking for git" HOT 7
- have searched on the goolge but can't find niof fix about Launch.json. I put "program": "lib/main.dart" but it still doesn't work. I would like to be able to help you how to fix "Your launch config refers to a program that does not exist. If you have problems launching, check the "program" field in your ".vscode/launch.json" file ." HOT 3
- Highligh issue with another textmate grammar HOT 1
- Error: Dart library 'dart:ui' is not available on this platform HOT 11
- Add `Import library with prefix` option HOT 3
- When attaching to Flutter web fails, the "Attaching..." notification stays on screen and the error message is not shown
- Dart extension doesn't start analyzer HOT 2
- `Restart Analysis Server` exits `DevTools` on Flutter projects HOT 1
- Don't prompt for Dart SDK updates when Dart SDK is found from a symlink in a Flutter SDK HOT 11
- Duplicate fields in debugger view HOT 13
- Breakpoints not triggering on web build HOT 9
- Missed snackbar.dart file path from fluent_ui.dart HOT 2
- Add an option to auto open DevTools in browser on start debugging HOT 1
- Debug breakpoints not triggering on iOS devices HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dart-code.